I re-enabled multiple data paths in my multidata branch (which is based on next and will go into 0.18.0 if we succeed here). Not entirely sure, if there is more to do to re-enable it in the launcher.
Can we have some tests please? Does it work for you? Or does it blow up again? When testing please make sure you have multiple data paths in use and there is actually some content in ore than on data path.
Multiple data paths
Re: Multiple data paths
Does the silence means it works for everybody or did nobody get around to testing it yet?
Re: Multiple data paths
It seems we will not get anymore testing. I am merging my branch into master now. if things blow up, we will see it soon enough.
- psi29a
- Posts: 5362
- Joined: 29 Sep 2011, 10:13
- Location: Belgium
- Gitlab profile: https://gitlab.com/psi29a/
- Contact:
Re: Multiple data paths
trial by fire, my favourite kind of testing...
Re: Multiple data paths
Does this enable having multiple BSAs and non-BSA'ed resources?
Re: Multiple data paths
No. We could do that all along.
Re: Multiple data paths
Finally had the time to look into this. I've sent you a pull request (to master) that fixes the data-local handling you re-enabled in commit 2284d76. It also fixes and re-enables the handling of multiple data paths (so you might want to pull it into multidata instead)
One thing: I noticed that data= entries in the local configuration file are completely ignored, I believe the culprit is the configuration manager. I believe this is not correct behaviour, right?
One thing: I noticed that data= entries in the local configuration file are completely ignored, I believe the culprit is the configuration manager. I believe this is not correct behaviour, right?
Re: Multiple data paths
You sure about that? If there are data paths in a higher priority cfg source, then all data paths from lower priority sources are completely discarded. Could it be that what you are seeing? Otherwise we have another bug.
Re: Multiple data paths
Yes I suspect that is what I'm seeing, I was under the impression that data entries were supposed to be merged.