Multiple data paths

Everything about development and the OpenMW source code.
Post Reply
User avatar
Zini
Posts: 5538
Joined: 06 Aug 2011, 15:16

Multiple data paths

Post by Zini »

I re-enabled multiple data paths in my multidata branch (which is based on next and will go into 0.18.0 if we succeed here). Not entirely sure, if there is more to do to re-enable it in the launcher.

Can we have some tests please? Does it work for you? Or does it blow up again? When testing please make sure you have multiple data paths in use and there is actually some content in ore than on data path.
User avatar
Zini
Posts: 5538
Joined: 06 Aug 2011, 15:16

Re: Multiple data paths

Post by Zini »

Does the silence means it works for everybody or did nobody get around to testing it yet?
User avatar
Zini
Posts: 5538
Joined: 06 Aug 2011, 15:16

Re: Multiple data paths

Post by Zini »

It seems we will not get anymore testing. I am merging my branch into master now. if things blow up, we will see it soon enough.
User avatar
psi29a
Posts: 5362
Joined: 29 Sep 2011, 10:13
Location: Belgium
Gitlab profile: https://gitlab.com/psi29a/
Contact:

Re: Multiple data paths

Post by psi29a »

trial by fire, my favourite kind of testing... :D
User avatar
Greendogo
Posts: 1467
Joined: 26 Aug 2011, 02:04

Re: Multiple data paths

Post by Greendogo »

Does this enable having multiple BSAs and non-BSA'ed resources?
User avatar
Zini
Posts: 5538
Joined: 06 Aug 2011, 15:16

Re: Multiple data paths

Post by Zini »

No. We could do that all along.
User avatar
Greendogo
Posts: 1467
Joined: 26 Aug 2011, 02:04

Re: Multiple data paths

Post by Greendogo »

I knew that...
User avatar
pvdk
Posts: 528
Joined: 12 Aug 2011, 16:34

Re: Multiple data paths

Post by pvdk »

Finally had the time to look into this. I've sent you a pull request (to master) that fixes the data-local handling you re-enabled in commit 2284d76. It also fixes and re-enables the handling of multiple data paths (so you might want to pull it into multidata instead)

One thing: I noticed that data= entries in the local configuration file are completely ignored, I believe the culprit is the configuration manager. I believe this is not correct behaviour, right?
User avatar
Zini
Posts: 5538
Joined: 06 Aug 2011, 15:16

Re: Multiple data paths

Post by Zini »

You sure about that? If there are data paths in a higher priority cfg source, then all data paths from lower priority sources are completely discarded. Could it be that what you are seeing? Otherwise we have another bug.
User avatar
pvdk
Posts: 528
Joined: 12 Aug 2011, 16:34

Re: Multiple data paths

Post by pvdk »

Yes I suspect that is what I'm seeing, I was under the impression that data entries were supposed to be merged.
Post Reply