[W10] Today's daily builds (5th Dec) not saving outdoors!

Support for running, installing or compiling OpenMW

Before you submit a bug report for the first time, please read: Bug reporting guidelines
Post Reply
User avatar
Sslaxx
Posts: 223
Joined: 12 Aug 2011, 18:59
Location: Malvern, UK
Github profile: https://github.com/Sslaxx/
Contact:

[W10] Today's daily builds (5th Dec) not saving outdoors!

Post by Sslaxx » 05 Dec 2018, 23:12

As per the subject line, really. The game crashes when attempting to create a save game outdoors; interiors seem unaffected. Latest daily build, Win10 64-bit. No obvious messages about this in openmw.log.
Last edited by Sslaxx on 07 Dec 2018, 19:14, edited 2 times in total.
Stuart "Sslaxx" Moore.

User avatar
Capostrophic
Posts: 469
Joined: 22 Feb 2016, 20:32

Re: [W10] Today's daily builds (5th Dec) not saving!

Post by Capostrophic » 06 Dec 2018, 00:11

The reason of the freezes is this commit.
shitty lingua anglica grammar ftw

User avatar
psi29a
Posts: 4366
Joined: 29 Sep 2011, 10:13
Github profile: https://github.com/psi29a/
Contact:

Re: [W10] Today's daily builds (5th Dec) not saving!

Post by psi29a » 06 Dec 2018, 09:54

Should that be reverted?

User avatar
AnyOldName3
Posts: 1192
Joined: 26 Nov 2015, 03:25

Re: [W10] Today's daily builds (5th Dec) not saving!

Post by AnyOldName3 » 06 Dec 2018, 16:30

Except for the issues it's causing, it's a good commit. It's something that's going to have to get done at some point, but it might be a reasonable idea to temporarily revert it until the issues it's exposing can be located and fixed.
AnyOldName3, Master of Shadows

User avatar
akortunov
Posts: 471
Joined: 13 Mar 2017, 13:49
Location: Samara, Russian Federation
Github profile: https://github.com/akortunov

Re: [W10] Today's daily builds (5th Dec) not saving!

Post by akortunov » 06 Dec 2018, 17:23

For me game freezes when OpenMW tries to take screenshot for savegame here.
I suppose it get a deadlock in the osg::ViewerBase::renderingTraversals(), when awaiting for _endDynamicDrawBlock.
Last edited by akortunov on 06 Dec 2018, 17:35, edited 2 times in total.

User avatar
AnyOldName3
Posts: 1192
Joined: 26 Nov 2015, 03:25

Re: [W10] Today's daily builds (5th Dec) not saving!

Post by AnyOldName3 » 06 Dec 2018, 17:34

Maybe our double-buffered geometries for skinned stuff aren't technically enough for current frame + previous frame + screenshot frame and this commit has made OSG start enforcing this.
AnyOldName3, Master of Shadows

User avatar
psi29a
Posts: 4366
Joined: 29 Sep 2011, 10:13
Github profile: https://github.com/psi29a/
Contact:

Re: [W10] Today's daily builds (5th Dec) not saving!

Post by psi29a » 06 Dec 2018, 20:27

Has any of the 360-screenshot code had an inpact/influence here?

Post Reply

Who is online

Users browsing this forum: No registered users and 1 guest