openmw.org

u srs

no, absolutely not

I know where at the point that we're discussing 'style' and best practices instead of further technical work... but still. Let's keep to the plan please.

But but... shadows r hoodge! And will need testing for weeks!

lysol wrote: ↑31 Jan 2019, 20:36 But but... shadows r hoodge! And will need testing for weeks!

Perfect for 0.46

I've already merged parts of 0.46 into my PR, so it would be a massive mess to even try and get it into 0.45, regardless of it also being a bad idea.

So, is it ready to merge?

It's time for general code review and thorough testing and bug hunting. If nothing comes up, it should be merged very soon. I think one of the settings doesn't do quite what it's supposed to, though, so there's probably something that needs changing.

A general round of reviews and testing, when we're comfortable, we'll merge.

Then come the nightlies and more testing for those living on the edge.

psi29a wrote: ↑31 Jan 2019, 20:38

lysol wrote: ↑31 Jan 2019, 20:36 But but... shadows r hoodge! And will need testing for weeks!

Perfect for 0.46

Just to clarify, yes, this is what I meant too.

Anyway, will the shadow settings get ingame adjustable settings now or in a later PR?

Akortunov started a PR against my fork for that, but it'll mostly need redoing as the set of available settings has changed.