Application: shihan42

Join the team. This area is for people who want to participate in OpenMW's development in one way or another.
Post Reply
shihan42
Posts: 5
Joined: 20 Feb 2023, 15:39
Gitlab profile: https://gitlab.com/shihan.42

Application: shihan42

Post by shihan42 »

Hi everyone,

as an avid player of the TES-series I decided to contribute to this wonderful project of yours. I'm a professional software developer with around 20 years of experience. The last years, I worked on a bunch of .Net Core projects, but my roots are C++ and graphics programming (I did several papers in the topic of ray and path tracing at university before changing into the industry).

This https://gitlab.com/OpenMW/openmw/-/issues/7214 piqued my interest. I gave it a try and came up with a possible solution.

Since I'm new here (in the forums, not at OpenMW in general), I'm unsure about the way you people do things.
Should I open a pull request? Or is there someone who first assigns me to the issue and then we do the pull stuff?

All the best
shihan42
User avatar
AnyOldName3
Posts: 2661
Joined: 26 Nov 2015, 03:25

Re: Application: shihan42

Post by AnyOldName3 »

Normally, there'd be some amount of discussion if the right implementation wasn't obvious, either on the tracker (best, as there's a clear record), Discord, or these forums, then someone would open a merge request on GitLab, which would be reviewed and iterated on until either it was good enough to merge or obviously not the right approach. Skipping the initial discussion can work, too, but sometimes leads to more redundant work. If you've already got something you can turn into an MR, though, the MR comments are as good a place to discuss it as anywhere else.
shihan42
Posts: 5
Joined: 20 Feb 2023, 15:39
Gitlab profile: https://gitlab.com/shihan.42

Re: Application: shihan42

Post by shihan42 »

Yeah, you are right. Discussing the issue and explorating possible approaches before starting to code is the more efficient way.
But while I was browsing the source, I felt myself urged to try to solve the mentioned issue :D

The next time, I'll start with the discussion first.
So, would I just choose any issue that seems to be free or is there a list of priorities or something like that?
User avatar
psi29a
Posts: 5355
Joined: 29 Sep 2011, 10:13
Location: Belgium
Gitlab profile: https://gitlab.com/psi29a/
Contact:

Re: Application: shihan42

Post by psi29a »

Welcome board!

I see you've been busy already with looking into issues and your first MR.

Please remember to add a changelog entry and yourself to the authors.md file :)

Is there anything in particular you're interested in?

Another question would be, what is your motivation to work on OpenMW? Everyone has an agenda (in a good way), just curious as to yours. :)
shihan42
Posts: 5
Joined: 20 Feb 2023, 15:39
Gitlab profile: https://gitlab.com/shihan.42

Re: Application: shihan42

Post by shihan42 »

psi29a wrote: 22 Feb 2023, 13:46 Is there anything in particular you're interested in?
At the moment, I'm trying to find my way around the project and to get a hang of how things are done, which issues are comfortable for me working on, and where to bring me in.

After that warm-up, I'd like to do things like code maintenance (feels almost relaxing to me), graphics programming, and working on the scripting system.


psi29a wrote: 22 Feb 2023, 13:46 Another question would be, what is your motivation to work on OpenMW? Everyone has an agenda (in a good way), just curious as to yours. :)
That's a good and valid question :D

Game engine recreation is a really interesting field for me. On one hand, one needs to understand what the original does and why it does it. On the other hand we can use modern things to extend the original in ways the devs didn't think about.

And I wanted to contribute to an open source project. Since I absolutely adore The Elder Scrolls and OpenMW makes a very profound impression, it was a logical choice :)
Post Reply