Shadows
- psi29a
- Posts: 5362
- Joined: 29 Sep 2011, 10:13
- Location: Belgium
- Gitlab profile: https://gitlab.com/psi29a/
- Contact:
Re: Shadows
no, absolutely not
I know where at the point that we're discussing 'style' and best practices instead of further technical work... but still. Let's keep to the plan please.
I know where at the point that we're discussing 'style' and best practices instead of further technical work... but still. Let's keep to the plan please.
Re: Shadows
But but... shadows r hoodge! And will need testing for weeks!
- psi29a
- Posts: 5362
- Joined: 29 Sep 2011, 10:13
- Location: Belgium
- Gitlab profile: https://gitlab.com/psi29a/
- Contact:
- AnyOldName3
- Posts: 2684
- Joined: 26 Nov 2015, 03:25
Re: Shadows
I've already merged parts of 0.46 into my PR, so it would be a massive mess to even try and get it into 0.45, regardless of it also being a bad idea.
Re: Shadows
So, is it ready to merge?
- AnyOldName3
- Posts: 2684
- Joined: 26 Nov 2015, 03:25
Re: Shadows
It's time for general code review and thorough testing and bug hunting. If nothing comes up, it should be merged very soon. I think one of the settings doesn't do quite what it's supposed to, though, so there's probably something that needs changing.
- psi29a
- Posts: 5362
- Joined: 29 Sep 2011, 10:13
- Location: Belgium
- Gitlab profile: https://gitlab.com/psi29a/
- Contact:
Re: Shadows
A general round of reviews and testing, when we're comfortable, we'll merge.
Then come the nightlies and more testing for those living on the edge.
Then come the nightlies and more testing for those living on the edge.
- AnyOldName3
- Posts: 2684
- Joined: 26 Nov 2015, 03:25
Re: Shadows
Akortunov started a PR against my fork for that, but it'll mostly need redoing as the set of available settings has changed.