Faction Requirements Not Met
Faction Requirements Not Met
It looks like my little girl made it to Master Wizard without meeting the faction requirements. She needed one skill at 80 - that would have been Alchemy, and two at 30. But, she only had one other favourite Mage Guild skill that high - Enchant. I checked UESP Wiki and the manual, but they're not really clear that it has to be a faction favourite skill. Is this a bug, or am I missing something?
Re: Faction Requirements Not Met
Correct me if I'm wrong, but it looks like we treat the primary skill as one of the two other required skills:
See /apps/openmw/mwmechanics/npcstats.cpp, lines 387ff; the error is in line 418.
We should check if there are exactly two favoured skills and use the existing return statement in that case. If there are more than two favoured skills, the iterator should be advanced by 2 and then checked against "rankData.mSkill2".
See /apps/openmw/mwmechanics/npcstats.cpp, lines 387ff; the error is in line 418.
Code: Select all
bool MWMechanics::NpcStats::hasSkillsForRank (const std::string& factionId, int rank) const
{
// [...]
if (*iter<rankData.mSkill1)
return false;
if (skills.size() < 2)
return true;
return *++iter>=rankData.mSkill2; // <= Here!
}
Re: Faction Requirements Not Met
OK, since it's not just me being confused, I've opened a bug report.
Re: Faction Requirements Not Met
For reference: Issue #5499.