Page 1 of 1

[W10] Today's daily builds (5th Dec) not saving outdoors!

Posted: 05 Dec 2018, 23:12
by Sslaxx
As per the subject line, really. The game crashes when attempting to create a save game outdoors; interiors seem unaffected. Latest daily build, Win10 64-bit. No obvious messages about this in openmw.log.

Re: [W10] Today's daily builds (5th Dec) not saving!

Posted: 06 Dec 2018, 00:11
by Capostrophic
The reason of the freezes is this commit.

Re: [W10] Today's daily builds (5th Dec) not saving!

Posted: 06 Dec 2018, 09:54
by psi29a
Should that be reverted?

Re: [W10] Today's daily builds (5th Dec) not saving!

Posted: 06 Dec 2018, 16:30
by AnyOldName3
Except for the issues it's causing, it's a good commit. It's something that's going to have to get done at some point, but it might be a reasonable idea to temporarily revert it until the issues it's exposing can be located and fixed.

Re: [W10] Today's daily builds (5th Dec) not saving!

Posted: 06 Dec 2018, 17:23
by akortunov
For me game freezes when OpenMW tries to take screenshot for savegame here.
I suppose it get a deadlock in the osg::ViewerBase::renderingTraversals(), when awaiting for _endDynamicDrawBlock.

Re: [W10] Today's daily builds (5th Dec) not saving!

Posted: 06 Dec 2018, 17:34
by AnyOldName3
Maybe our double-buffered geometries for skinned stuff aren't technically enough for current frame + previous frame + screenshot frame and this commit has made OSG start enforcing this.

Re: [W10] Today's daily builds (5th Dec) not saving!

Posted: 06 Dec 2018, 20:27
by psi29a
Has any of the 360-screenshot code had an inpact/influence here?