Thief Companion Constance menu topics not all there

[argonvegell]

download and place into data files folder and then select from launcher.
(worked for a good time) it automatically put it to load after constance 1.0 esp overriding wanted parts of the original ingame
a note that you have to rename the .txt out as it's for webpage saving

Thank you, it's working as expected now, the follow option is visible and works as expected, thanks for all your help! I'll report any other problems that I encounter with the Constance mod in the future, thanks.

Will your path be applied to future versions of OpenMW?

[sjek]

no. it can probaply be released as patch somewhere later if needed (some are bugs in openmw) and (asking author is always good) but the openmw is just an engine and doesn't host a mod library on it's own

[argonvegell]

Okay, thanks for your help once again, and I hope users wanting to use the Constance mod can find their way to your patch.

Question, how is the Julan Ashlander mod doing? Is it working as intended yet? I usually play Constance and Julan as my adventuring companions.

[sjek]

don't know exactly. my testing is always trailing from direction to another but they both use grumpy's scripts so possibly related on not local function and addtopic " " missing but otherwise it's heavily modified. tesCS thought makes checking much easier

[argonvegell]

new problems with the constance mod:

-Constance doesn't follow player when casting intervention spells.
-escort missions do not work while Constance is following player, the escortee will only follow if I tell Constance to stay.

Are these problems with the OpenMW engine or with the mod itself?

[sjek]

viewtopic.php?f=2&t=3221 the interventions and recall uses geteffect to make constance interfere and it should be fixed in current git. using windows ?

on the not following part it was that warping code. coordinate checking might be under same code in openmw as aifollow so it blocks up. deleting that part of the script solved the problem

Spoiler: Show

Code: Select all

if ( GetCurrentAiPackage == 3 ) ; warping
  if ( noWarp == 0 )
    set ax to ( Player->GetPos x )
    set ay to ( Player->GetPos y )

  if ( doOnce == 0 )
    set bx to ( Player->GetPos x )
    set by to ( Player->GetPos y )
    set bz to ( Player->GetPos z )
    set doOnce to 1
  endif

  set t1 to ( ax - bx )
  set t1 to ( t1 * t1 )
  set t2 to ( ay - by )
  set t2 to ( t2 * t2 )
  set t1 to ( t1 + t2 )
  set coDist to ( GetSquareRoot, t1 )

  if ( coDist > 360 )
    set doOnce to 0
  endif

  if ( coDist > 180 )
  if ( doOnce2 == 0 )
    set cx to ( Player->GetPos x )
    set cy to ( Player->GetPos y )
    set cz to ( Player->GetPos z )
    set doOnce2 to 1
  endif
  endif

  set t3 to ( ax - cx )
  set t3 to ( t3 * t3 )
  set t4 to ( ay - cy )
  set t4 to ( t4 * t4 )
  set t3 to ( t3 + t4 )
  set coDist2 to ( GetSquareRoot, t3 )

  if ( coDist2 > 360 )
    set doOnce2 to 0
  endif

if ( warp == 0 )
	if ( GetDistance Player > 680 )
		if ( coDist > 300 )
			if ( coDist < 680 )
				SetPos x bx
				SetPos y by
				SetPos z bz
				AiFollow Player 0 0 0 0
			endif
		elseif ( coDist2 > 300 )
			if ( coDist2 < 680 )
				SetPos x cx
				SetPos y cy
				SetPos z cz
				AiFollow Player 0 0 0 0
			endif
		endif
	endif
endif
endif

that can be done much cleanly with position on openmw -> tests

[argonvegell]

viewtopic.php?f=2&t=3221 the interventions and recall uses geteffect to make constance interfere and it should be fixed in current git. using windows ?

on the not following part it was that warping code. coordinate checking might be under same code in openmw as aifollow so it blocks up. deleting that part of the script solved the problem

Spoiler: Show

Code: Select all

if ( GetCurrentAiPackage == 3 ) ; warping
  if ( noWarp == 0 )
    set ax to ( Player->GetPos x )
    set ay to ( Player->GetPos y )

  if ( doOnce == 0 )
    set bx to ( Player->GetPos x )
    set by to ( Player->GetPos y )
    set bz to ( Player->GetPos z )
    set doOnce to 1
  endif

  set t1 to ( ax - bx )
  set t1 to ( t1 * t1 )
  set t2 to ( ay - by )
  set t2 to ( t2 * t2 )
  set t1 to ( t1 + t2 )
  set coDist to ( GetSquareRoot, t1 )

  if ( coDist > 360 )
    set doOnce to 0
  endif

  if ( coDist > 180 )
  if ( doOnce2 == 0 )
    set cx to ( Player->GetPos x )
    set cy to ( Player->GetPos y )
    set cz to ( Player->GetPos z )
    set doOnce2 to 1
  endif
  endif

  set t3 to ( ax - cx )
  set t3 to ( t3 * t3 )
  set t4 to ( ay - cy )
  set t4 to ( t4 * t4 )
  set t3 to ( t3 + t4 )
  set coDist2 to ( GetSquareRoot, t3 )

  if ( coDist2 > 360 )
    set doOnce2 to 0
  endif

if ( warp == 0 )
	if ( GetDistance Player > 680 )
		if ( coDist > 300 )
			if ( coDist < 680 )
				SetPos x bx
				SetPos y by
				SetPos z bz
				AiFollow Player 0 0 0 0
			endif
		elseif ( coDist2 > 300 )
			if ( coDist2 < 680 )
				SetPos x cx
				SetPos y cy
				SetPos z cz
				AiFollow Player 0 0 0 0
			endif
		endif
	endif
endif
endif

that can be done much cleanly with position on openmw -> tests

Thanks for the reply.

So, the part where Constance isn't following the player when casting intervention spells, those are bugs within OpenMW?

So, for clarity, I have to open up 'constance12patchopenmw.omwaddon' and delete the codes that you show on here?

How do I edit .omwaddon files? I've tried using mousepad to access it, by putting back the .txt on the end of the file, but it can't read it.

[sjek]

ok.

you have to start up openmw-cs from where openmw.exe is located. then choosing edit file and selecting the patch it loads up and in upper bar from mechanics there is scripts which opens up.

in there ID AA_con_compScript21 is shown modified right up on the front when ordered by name (default, i think)
you just need to right lick on the name -> edit record and the code is 3 / 4 way down in script window

this will cause her to follow normally without all the clipping relative to player position so if you cast windwalker scroll she will follow with her normal speed as it's scaled on if block after that code.

anyway more specific fix seems to be remove aifollow from the above
( if removing all, leaving getcurrentaipackage == 3 )

Code: Select all

if ( warp == 0 )
	if ( GetDistance Player > 680 )
		if ( coDist > 300 )
			if ( coDist < 680 )
				SetPos x bx
				SetPos y by
				SetPos z bz
				AiFollow Player 0 0 0 0
			endif
		elseif ( coDist2 > 300 )
			if ( coDist2 < 680 )
				SetPos x cx
				SetPos y cy
				SetPos z cz
				AiFollow Player 0 0 0 0
			endif
		endif
	endif
endif
endif

which is workaround for vanilla reseting AI on repositioning. there's something fishy on openmw side as well

with mirisa (randomly selected from follownow variables) the blocking up happens after issuing aifollows from dialogue. expecially after "let's go" constance and then her. there might be distance checks overlapping main problem being with companion variable which is set on the second take and the distance of mirisa checked against npcvoicedistance but then again she will stay back to 900 which is over 750. namely

get trought initial topics with constance to get aifollow to initialise
(follownow is thus set from script to 1 and doesn't interfere further)
-> follows at distance 360
placeatpc mirisa 1 100 0 and get the travel together topic trought to set aifollow
-> follows at distance 540
then with constance select follow and let's go setting the companion var to 1
-> clipping between 337 and 664
then travel together, mirisa which sets aifollow again as in first time causing
-> follows at 900

that is when those aifollows are removed from the code and with them constance needs to place on wander with wait to get mirisa to follow.
(edit: taking out the positions and aifollows result them to be first those c400, m600 and then skips to c800, m1000, c1200, m1400, c1600 very roughly when alternating aifollows. the engine thinks of adding ghost companions)

does same order happen with your setup ie. constance, companion, constance, companion -> stuck ?
companions ?

(intervention not working is openmw bug)

[argonvegell]

sorry i didn't understand what to do at all, I opened up OpenMW-CS, went to the modified script, selected edit record.

The part that confused me was 'edit record and the code is 3 / 4 way down in script window' all the way down, got confused.

sorry, not really a programmer.

[sjek]

3 / 4 part from the lenght of the whole script. just remove them or comment out by placing ; in front of them like

Code: Select all

; aitravel player 0 0 0 0 ;isn't read in runtime and same as empty space or no line at all

and then save. you can keep the cs open and start the openmw. mods are keep as selected and check ingame -> quit -> change mod -> start again .p
using openmw.cfg extra options to make it fast. it's also easy to cheat that way and more playing with console than game actually.

not here also. c++ is (looks) crazy althought the concept of class function and namespaces is simple ( somewhat custom functions and lists for gears, types goes to compile time code handling ie. you can crash it in processor level althought would seem fine )

edit: if shows i'm done with edit's