OpenMW 0.18 RC crash after "coc" command on OS X

[scrawl]

Also, the crash should go away when commenting

mWindow->update();

and

MWBase::Environment::get().getInputManager()->update(0, true);

in loadingscreen.cpp?

[Zini]

Ah, sorry. I miss-interpreted corristo's posting and then tried to address a problem, that has already been fixed.

Well, I am mostly out of ideas right now. The main loop might be an issue. If that does not help, you will have to debug where in the capture function the crash happens.

[corristo]

Disabled custom main loop. Crash is here.

Going to try scrawl's suggestions.

[corristo]

Looks like it's sufficient to comment this:

Code: Select all

MWBase::Environment::get().getInputManager()->update(0, true);

And no overflow crash mentioned in commetns above tihs call o_O

[scrawl]

Some more light on the problem:
Due to the implementation of the OSX OIS keyboard, we cannot update input from a listener that was called by the input update. This happened because when using "coc" and pressing enter, the input listener causes a cell change and starts loading, and from this loading method the input is updated again.

I have sent a pull request to disable the input update during loading as a hotfix.