Change to stl::filesystem from Boost::filesystem

Everything about development and the OpenMW source code.
User avatar
psi29a
Posts: 4896
Joined: 29 Sep 2011, 10:13
Location: Belgium
Gitlab profile: https://gitlab.com/psi29a/
Contact:

Re: Change to stl::filesystem from Boost::filesystem

Post by psi29a » 17 Oct 2019, 15:50

At this rate... VSG will be ready before OpenMW gets to 1.0 :/

User avatar
AnyOldName3
Posts: 1905
Joined: 26 Nov 2015, 03:25

Re: Change to stl::filesystem from Boost::filesystem

Post by AnyOldName3 » 17 Oct 2019, 16:20

It's much easier to work on something new than maintain legacy stuff. We need to keep compatibility with all the dumb decisions Bethesda made and loads of legacy bloat in OSG, but VSG doesn't need to copy anything.
AnyOldName3, Master of Shadows

User avatar
psi29a
Posts: 4896
Joined: 29 Sep 2011, 10:13
Location: Belgium
Gitlab profile: https://gitlab.com/psi29a/
Contact:

Re: Change to stl::filesystem from Boost::filesystem

Post by psi29a » 18 Oct 2019, 10:45

So OpenMW would have to two support two renderes?

User avatar
AnyOldName3
Posts: 1905
Joined: 26 Nov 2015, 03:25

Re: Change to stl::filesystem from Boost::filesystem

Post by AnyOldName3 » 18 Oct 2019, 17:18

We don't need to add support for VSG, but if we do, we would need to add it as a second renderer.
AnyOldName3, Master of Shadows

User avatar
psi29a
Posts: 4896
Joined: 29 Sep 2011, 10:13
Location: Belgium
Gitlab profile: https://gitlab.com/psi29a/
Contact:

Re: Change to stl::filesystem from Boost::filesystem

Post by psi29a » 21 Oct 2019, 09:14

I have a WIP branch... updates appveyor to drop msvc 2015, adds msvc 2019 (2017 and 2019), linux drops gcc-5 and we use std::filesytem instead of std::experimental:filesystem in bsatool. Just bsatool for now, easy/small to test as my other MR is full of merge conflicts. I don't want to come back to this after a month and have more conflicts.

The main problem is still MacOS. std::filesystem/std::experimental::filesystem isn't there yet until MacOS 10.15 and Travis doesn't have that yet. Having the SDK installed is not enough, the libstdc++ of the system itself has to be updated and Travis still uses 10.14.

It might make life harder for Android people. It also means that tes3mp will likely also have to adapt.

davidcernat
Posts: 232
Joined: 19 Jul 2016, 01:02

Re: Change to stl::filesystem from Boost::filesystem

Post by davidcernat » 22 Oct 2019, 09:51

psi29a wrote:
21 Oct 2019, 09:14
It also means that tes3mp will likely also have to adapt.
No need to worry about that. It's the easiest thing for TES3MP to adapt to.

User avatar
Greendogo
Posts: 1452
Joined: 26 Aug 2011, 02:04

Re: Change to stl::filesystem from Boost::filesystem

Post by Greendogo » 26 Oct 2019, 10:44

psi29a wrote:
21 Oct 2019, 09:14
The main problem is still MacOS. std::filesystem/std::experimental::filesystem isn't there yet until MacOS 10.15 and Travis doesn't have that yet. Having the SDK installed is not enough, the libstdc++ of the system itself has to be updated and Travis still uses 10.14.
MacOS 10.15 was just released about a week ago and Travis already has up to Xcode 11.2 support (which has std::filesystem support). It's just a matter of time now.

User avatar
psi29a
Posts: 4896
Joined: 29 Sep 2011, 10:13
Location: Belgium
Gitlab profile: https://gitlab.com/psi29a/
Contact:

Re: Change to stl::filesystem from Boost::filesystem

Post by psi29a » 27 Oct 2019, 21:25

Sadly not... they use Xcode 11.2 with 10.15 SDK on 10.14 MacOS. So no go until they finally get around to actually running MacOS 10.15 (libstdc++), so yeah... as I've said, we''be been waiting years now.

https://docs.travis-ci.com/user/referen ... os-version

My latest MR is here if you would like to follow along:
https://github.com/OpenMW/openmw/pull/2561

original was from 2017 was:
https://github.com/OpenMW/openmw/pull/1526

Been waiting, literately for years now.

User avatar
Greendogo
Posts: 1452
Joined: 26 Aug 2011, 02:04

Re: Change to stl::filesystem from Boost::filesystem

Post by Greendogo » 28 Oct 2019, 09:18

Greendogo wrote:
26 Oct 2019, 10:44
MacOS 10.15 was just released about a week ago and Travis already has up to Xcode 11.2 support (which has std::filesystem support). It's just a matter of time now.
psi29a wrote:
27 Oct 2019, 21:25
Sadly not...
I bet you that it is indeed a matter of time. Some number of picoseconds greater than 0 from now until the end of the universe.

Anyway, I'll bet you a dollar it's done before 2020. :D


Post Reply