Sky

[ezzetabi]

You did not, thanks! What about adding in the media page a link to the wiki media page?

[lgromanowski]

You did not, thanks! What about adding in the media page a link to the wiki media page?

Done.

[corristo]

Hi, I got following error trying to build "next" branch with clang:

Code: Select all

/Users/corristo/Projects/OpenMW/next/apps/openmw/mwrender/sky.cpp:279:14: error: arithmetic on a pointer to void
        pData+=vertex_size;
        ~~~~~^

looks like void pointer arithmetics is GCC extension and it fails with Clang and probably would fail with MSVC++ (related SO post)
So I think this can be changed to

Code: Select all

pData = (char *)pData + vertex_size;

[Zini]

Actually, gcc doesn't except it without a warning either. I saw it while testing the branch, but didn't get to look into it, because you guys are bombarding me with pull requests.

Using a void pointer doesn't look like a good idea in the first place, if you do anything with it beyond passing it around. But it seems that is how OGRE defines its API.

Anyway, I pushed a fix (using C++ casts instead of C casts).

[Zini]

@scrawl: I see a lot of changes in my commit that do nothing than remove spaces at the end of the line. If it isn't too inconvenient for you, could you please configure your editor so that it removes these automatically (on save or whatever you have available). Otherwise people modifying your code will end up with lots of unnecessary changes as in my recent commit.

[ElderTroll]

Zini, is the image of the sky you posted of vanilla Morrowind or a mod?

[Zini]

Vanilla MW.

[ElderTroll]

I thought so. It was a question a user on a forum had. Thanks for clearing it up.

[jhooks1]

Damn, the new sky looks awesome!!! Just got the master branch working.

[jhooks1]

Also who added the code for limiting the view in exteriors? This is awesome, exteriors perform great!!