Shadows

Everything about development and the OpenMW source code.
User avatar
Capostrophic
Posts: 652
Joined: 22 Feb 2016, 20:32

Re: Shadows

Post by Capostrophic » 31 Jan 2019, 19:11

u srs

User avatar
psi29a
Posts: 4630
Joined: 29 Sep 2011, 10:13
Location: Belgium
Gitlab profile: https://gitlab.com/psi29a/
Contact:

Re: Shadows

Post by psi29a » 31 Jan 2019, 19:32

no, absolutely not

I know where at the point that we're discussing 'style' and best practices instead of further technical work... but still. Let's keep to the plan please. :)

User avatar
lysol
Posts: 1316
Joined: 26 Mar 2013, 01:48
Location: Sweden

Re: Shadows

Post by lysol » 31 Jan 2019, 20:36

But but... shadows r hoodge! And will need testing for weeks!
Normal mapped texture replacers, exclusive for OpenMW:
My Nexus page

User avatar
psi29a
Posts: 4630
Joined: 29 Sep 2011, 10:13
Location: Belgium
Gitlab profile: https://gitlab.com/psi29a/
Contact:

Re: Shadows

Post by psi29a » 31 Jan 2019, 20:38

lysol wrote:
31 Jan 2019, 20:36
But but... shadows r hoodge! And will need testing for weeks!
Perfect for 0.46

User avatar
AnyOldName3
Posts: 1536
Joined: 26 Nov 2015, 03:25

Re: Shadows

Post by AnyOldName3 » 31 Jan 2019, 20:50

I've already merged parts of 0.46 into my PR, so it would be a massive mess to even try and get it into 0.45, regardless of it also being a bad idea.
AnyOldName3, Master of Shadows

User avatar
Br0ken
Posts: 241
Joined: 02 Apr 2012, 05:54
Location: Siberia

Re: Shadows

Post by Br0ken » 31 Jan 2019, 21:10

So, is it ready to merge?

User avatar
AnyOldName3
Posts: 1536
Joined: 26 Nov 2015, 03:25

Re: Shadows

Post by AnyOldName3 » 31 Jan 2019, 21:16

It's time for general code review and thorough testing and bug hunting. If nothing comes up, it should be merged very soon. I think one of the settings doesn't do quite what it's supposed to, though, so there's probably something that needs changing.
AnyOldName3, Master of Shadows

User avatar
psi29a
Posts: 4630
Joined: 29 Sep 2011, 10:13
Location: Belgium
Gitlab profile: https://gitlab.com/psi29a/
Contact:

Re: Shadows

Post by psi29a » 31 Jan 2019, 21:36

A general round of reviews and testing, when we're comfortable, we'll merge.

Then come the nightlies and more testing for those living on the edge.

User avatar
lysol
Posts: 1316
Joined: 26 Mar 2013, 01:48
Location: Sweden

Re: Shadows

Post by lysol » 31 Jan 2019, 22:21

psi29a wrote:
31 Jan 2019, 20:38
lysol wrote:
31 Jan 2019, 20:36
But but... shadows r hoodge! And will need testing for weeks!
Perfect for 0.46
Just to clarify, yes, this is what I meant too.

Anyway, will the shadow settings get ingame adjustable settings now or in a later PR?
Normal mapped texture replacers, exclusive for OpenMW:
My Nexus page

User avatar
AnyOldName3
Posts: 1536
Joined: 26 Nov 2015, 03:25

Re: Shadows

Post by AnyOldName3 » 31 Jan 2019, 23:50

Akortunov started a PR against my fork for that, but it'll mostly need redoing as the set of available settings has changed.
AnyOldName3, Master of Shadows

Post Reply