cmake improvements

Everything about development and the OpenMW source code.
User avatar
pvdk
Posts: 523
Joined: 12 Aug 2011, 16:34

Re: cmake improvements

Post by pvdk » 28 Jan 2012, 12:56

Indeed, it does have that problem. But it does prevent non-source files from being included, so it's preferable over the current solution. However, if we want to prevent people having to re-run CMake after each git pull or manual addition of files we'll have to explicitly specify the source files again, just like you say.

User avatar
Zini
Posts: 5537
Joined: 06 Aug 2011, 15:16

Re: cmake improvements

Post by Zini » 28 Jan 2012, 13:06

I am not sure if we understand each other. We currently are specifying the source files (just not the hpp/cpp part). This works nicely except for a few rare edge cases.

The problem of including non-source files could be easily addressed by just adjusting the GLOB part of the macro. No need for any larger changes.

User avatar
pvdk
Posts: 523
Joined: 12 Aug 2011, 16:34

Re: cmake improvements

Post by pvdk » 28 Jan 2012, 13:22

Oh, my bad! I thought your solution had the same pitfalls as mine. In that case, disregard my suggestion and fix the macro to exclude .hidden files and other garbage.

User avatar
Zini
Posts: 5537
Joined: 06 Aug 2011, 15:16

Re: cmake improvements

Post by Zini » 28 Jan 2012, 14:17

Fix in cmakefix branch. Testing welcome.

User avatar
pvdk
Posts: 523
Joined: 12 Aug 2011, 16:34

Re: cmake improvements

Post by pvdk » 30 Jan 2012, 04:17

Works like a charm, thanks!

Post Reply