Support for Black Soul Gems

Feedback on past, current, and future development.
Post Reply
zackogenic
Posts: 13
Joined: 21 Apr 2015, 21:17

Support for Black Soul Gems

Post by zackogenic » 17 Apr 2020, 16:45

Hello, I created the mod "Black Soul Gems" for OpenMW a while ago: https://www.nexusmods.com/morrowind/mods/45902

The scripting in the mod makes it non-feasable to actually use.

However, recently I started playing around with the OpenMW source, and have found it's pretty simple to add support for this to the engine directly.

Here is the mwmechanics/actors.cpp with the needed changes: https://pastebin.com/fXwacTx7

and the mwclass/misc.cpp with more of the changes: https://pastebin.com/jBPFjC4i

Of course the recharge and enchanting menus need some changes too, but it's really simple stuff.

Would this be a change that could be added to the engine, like compatibility for graphic herbalism was? It would have no change to players who are playing without the required mod.

Thanks.

User avatar
Capostrophic
Posts: 768
Joined: 22 Feb 2016, 20:32

Re: Support for Black Soul Gems

Post by Capostrophic » 18 Apr 2020, 10:39

Sorry, it really should be up to mods to add black soul gems. Trapping NPC "souls" (which is a concept not present in the current ESM format by the way) is a significant gameplay change. Some legacy mods may rely on the vanilla handling of misc_soulgem_black ID and overriding the behavior of such objects on engine level would break them.

silentthief
Posts: 435
Joined: 18 Apr 2013, 01:20
Location: Currently traversing the Ascadian Isles

Re: Support for Black Soul Gems

Post by silentthief » 18 Apr 2020, 14:49

Capo is right. However, hang onto those files just in case. They may someday be useful if/when oblivion support is looked into.

ST
"You like to dance close to the fire, don't you?."

zackogenic
Posts: 13
Joined: 21 Apr 2015, 21:17

Re: Support for Black Soul Gems

Post by zackogenic » 18 Apr 2020, 21:45

Capostrophic wrote:
18 Apr 2020, 10:39
Sorry, it really should be up to mods to add black soul gems. Trapping NPC "souls" (which is a concept not present in the current ESM format by the way) is a significant gameplay change. Some legacy mods may rely on the vanilla handling of misc_soulgem_black ID and overriding the behavior of such objects on engine level would break them.
NPC souls isn't a concept in oblivion either, it just uses a single value for all black souls.

The legacy issue could be solved with a more specific ID like misc_soulgem_omwblacksoulgem.

Adding black soul gems with mods without stupid elaborate scripts or lua scripting isn't really feasible right now either.

User avatar
Capostrophic
Posts: 768
Joined: 22 Feb 2016, 20:32

Re: Support for Black Soul Gems

Post by Capostrophic » 18 Apr 2020, 23:08

Wait until Lua scripting is added then.

Post Reply