OpenMW 0.45.0

Anything related to PR, release planning and any other non-technical idea how to move the project forward should be discussed here.
User avatar
psi29a
Posts: 4916
Joined: 29 Sep 2011, 10:13
Location: Belgium
Gitlab profile: https://gitlab.com/psi29a/
Contact:

Re: OpenMW 0.45.0

Post by psi29a » 30 Oct 2018, 21:49

Capostrophic wrote:
30 Oct 2018, 21:43
Since psi29a is going to be excessively merge-happy these days, what is decided about the "contributor adds the changelog entry" policy of 0.45.0?

IMO changelog micromanaging was extremely messy during these 5 months and if returning to the "legacy" changelog managing style is considered personally I vote for that. :oops: :oops: :oops:
:oops: I merged one PR and Zini merged one MR... after 0.45 was branched, didn't realize that that was me being merge-happy

I'm already on top of the changelog entries...

https://gitlab.com/OpenMW/openmw/merge_requests/44

How is asking for a changelog entry micromanaging and why do you consider it messy? It's worth discussing. If everyone would rather abandon it, cool. The working theory (and practical side as seen in other projects) is that it alleviates additional work of having to create a changelog at the end of the development cycle.

User avatar
psi29a
Posts: 4916
Joined: 29 Sep 2011, 10:13
Location: Belgium
Gitlab profile: https://gitlab.com/psi29a/
Contact:

Re: OpenMW 0.45.0

Post by psi29a » 30 Oct 2018, 22:51

Back up the truck here... it's the end of 0.45 so that means we need to figure out what to do with the changelog experiment.

I get the feeling (well, told by others) that it is adding more bureaucracy and barrier to entries than necessary and that we have an issue-tracker (GL) that does the job for us.

Time to sound off everyone... what do we think?

User avatar
AnyOldName3
Posts: 1939
Joined: 26 Nov 2015, 03:25

Re: OpenMW 0.45.0

Post by AnyOldName3 » 30 Oct 2018, 23:31

I, as someone who's not created a single PR which needed a changelog entry during the 0.45 era, think it's a good idea. It's certainly a lot less hassle than having to create an issue report if you stumble upon something that looks stupid and fix it while working on something else.
AnyOldName3, Master of Shadows

User avatar
Capostrophic
Posts: 768
Joined: 22 Feb 2016, 20:32

Re: OpenMW 0.45.0

Post by Capostrophic » 31 Oct 2018, 00:00

My conversation with psi29a in Discord:
Spoiler: Show
It's still not a bad idea to keep track of stuff that is not pathetically minor -- but on the tracker itself, not in the changelog. That was scrawl's view on it too AFAIK. Asking the reporter to file a bug report/feature request is fine (you can clearly see the issues of each set milestone after all even after the move from redmine to gitlab), making the changelog volatile for the exact same purpose of record keeping is probably not.

User avatar
AnyOldName3
Posts: 1939
Joined: 26 Nov 2015, 03:25

Re: OpenMW 0.45.0

Post by AnyOldName3 » 31 Oct 2018, 00:58

We should probably get Zini's and Raevol's opinions on this, too, as they were both one-man-armying a lot of this work before.
AnyOldName3, Master of Shadows

User avatar
Zini
Posts: 5538
Joined: 06 Aug 2011, 15:16

Re: OpenMW 0.45.0

Post by Zini » 31 Oct 2018, 10:02

I was not in favour of the new approach at first. But I have started to like it. Its not so much that it cuts down my workload, but it is less error prone.

User avatar
Zini
Posts: 5538
Joined: 06 Aug 2011, 15:16

Re: OpenMW 0.45.0

Post by Zini » 31 Oct 2018, 10:04

@Capostrophic Are you completely unable to reproduce the bug? Happens everywhere for me. Well everywhere, as long as the cell has NPCs in it. If you can't reproduce it, would it help if I got you a stack backtrace?

User avatar
Capostrophic
Posts: 768
Joined: 22 Feb 2016, 20:32

Re: OpenMW 0.45.0

Post by Capostrophic » 31 Oct 2018, 12:45

Yep, I don't see anything wrong logged when I open arbitrary cell views including those with NPCs and creatures save for useless OpenGL warnings which are not connected to actor rendering (I got these even in exterior cells without any actors) whether I run editor directly or with gdb (with or without catching exceptions).

Not sure. Probably.

User avatar
Zini
Posts: 5538
Joined: 06 Aug 2011, 15:16

Re: OpenMW 0.45.0

Post by Zini » 31 Oct 2018, 13:21

Odd. I don't get any OpenGL errors.

Anyway, here is the backtrace:
#0 0x00007ffff30bfa5e in ?? () from /lib/x86_64-linux-gnu/libc.so.6
#1 0x00007ffff39c44dd in std::string::_M_mutate(unsigned long, unsigned long, unsigned long) ()
from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#2 0x00007ffff39c4546 in std::string::_M_leak_hard() () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#3 0x0000000000610af7 in _M_leak (this=0x7fffffffa5e0) at /usr/include/c++/4.8/bits/basic_string.h:317
#4 operator[] (__pos=0, this=0x7fffffffa5e0) at /usr/include/c++/4.8/bits/basic_string.h:849
#5 lowerCaseInPlace (
inout="\300,\020\003\000\000\000\000\340\070\020\003", '\000' <repeats 20 times>, "\340:\020\003\000\000\000\000\000\024\020\003", '\000' <repeats 12 times>, "\240B\020\003", '\000' <repeats 12 times>, "\200\061\020\003\000\000\000\000`1\020\003\000\000\000\000\000\061\020\003", '\000' <repeats 20 times>, " 1\020\003\000\000\000\000p\022\020\003", '\000' <repeats 12 times>, "\300:\020\003", '\000' <repeats 20 times>, "\300B\020\003\000\000\000\000\370\324\316\002", '\000' <repeats 12 times>, "A\000\000\000\000\000\000\000\001\000\000\000\377\177\000\000"...)
at /home/marc/OpenMW/openmw/./components/misc/stringops.hpp:173
#6 Misc::StringUtils::lowerCase (in=...) at /home/marc/OpenMW/openmw/./components/misc/stringops.hpp:180
#7 0x0000000000679bf2 in CSMWorld::Collection<ESM::BodyPart, CSMWorld::IdAccessor<ESM::BodyPart> >::searchId (
this=0x15ea138, id=...) at /home/marc/OpenMW/openmw/apps/opencs/model/world/collection.hpp:482
#8 0x00000000007d7b46 in CSVRender::Actor::getBodyPartMesh ([email protected]=0x23fd900,
bodyPartId="\300,\020\003\000\000\000\000\340\070\020\003", '\000' <repeats 20 times>, "\340:\020\003\000\000\000\000\000\024\020\003", '\000' <repeats 12 times>, "\240B\020\003", '\000' <repeats 12 times>, "\200\061\020\003\000\000\000\000`1\020\003\000\000\000\000\000\061\020\003", '\000' <repeats 20 times>, " 1\020\003\000\000\000\000p\022\020\003", '\000' <repeats 12 times>, "\300:\020\003", '\000' <repeats 20 times>, "\300B\020\003\000\000\000\000\370\324\316\002", '\000' <repeats 12 times>, "A\000\000\000\000\000\000\000\001\000\000\000\377\177\000\000"...) at /home/marc/OpenMW/openmw/apps/opencs/view/render/actor.cpp:122
---Type <return> to continue, or q <return> to quit---
#9 0x00000000007d7f32 in CSVRender::Actor::loadBodyParts ([email protected]=0x23fd900)
at /home/marc/OpenMW/openmw/apps/opencs/view/render/actor.cpp:100
#10 0x00000000007d86f1 in CSVRender::Actor::update (this=0x23fd900)
at /home/marc/OpenMW/openmw/apps/opencs/view/render/actor.cpp:52
#11 0x00000000007da6c7 in CSVRender::Object::update ([email protected]=0x30fd5e0)
at /home/marc/OpenMW/openmw/apps/opencs/view/render/object.cpp:122
#12 0x00000000007dd07a in CSVRender::Object::Object (this=0x30fd5e0, data=..., parentNode=0x2c6a940,
id="ref#92771", referenceable=<optimised out>, forceBaseToZero=<optimised out>)
at /home/marc/OpenMW/openmw/apps/opencs/view/render/object.cpp:455
#13 0x00000000007e0113 in CSVRender::Cell::addObjects ([email protected]=0x2bffd90, [email protected]=0,
end=316110) at /home/marc/OpenMW/openmw/apps/opencs/view/render/cell.cpp:93
#14 0x00000000007e06d8 in CSVRender::Cell::Cell (this=0x2bffd90, data=..., rootNode=0x2af2120, id=...,
deleted=<optimised out>) at /home/marc/OpenMW/openmw/apps/opencs/view/render/cell.cpp:189
#15 0x00000000007c5f58 in CSVRender::PagedWorldspaceWidget::addCellToScene ([email protected]=0x2a54260,
coordinates=...) at /home/marc/OpenMW/openmw/apps/opencs/view/render/pagedworldspacewidget.cpp:452
#16 0x00000000007c63eb in CSVRender::PagedWorldspaceWidget::adjustCells ([email protected]=0x2a54260)
at /home/marc/OpenMW/openmw/apps/opencs/view/render/pagedworldspacewidget.cpp:89
#17 0x00000000007c6d20 in CSVRender::PagedWorldspaceWidget::setCellSelection (this=0x2a54260, selection=...)
at /home/marc/OpenMW/openmw/apps/opencs/view/render/pagedworldspacewidget.cpp:629
#18 0x00000000007c6d90 in CSVRender::PagedWorldspaceWidget::useViewHint (this=0x2a54260,
hint="\300B\020\003\000\000\000\000\070\071\071\275\377\177\000\000\316D;\234\300\354IQ!\001\000\000\000\000\000\000\260\035\332", '\000' <repeats 13 times>, "\001\000\000\000\000\000\000\000\210\"\326\002\000\000\000\000\002\000\000\000\271ܡ@\340\306\020\003", '\000' <repeats 18 times>, "\200\277", '\000' <repeats 22 times>, "\200\277---Type <return> to continue, or q <return> to quit---
\000\025\[email protected]\a\342\[email protected]\220\307\020\003\000\000\000\000\230\307\020\003\000\000\000\000\230\307\020\003", '\000' <repeats 12 times>, "\005\000\000\000\022[L\300", '\000' <repeats 12 times>, "P\252\[email protected]\000\000\000\000\000\000\000\000\001v2A\000\000\000\000"...)
at /home/marc/OpenMW/openmw/apps/opencs/view/render/pagedworldspacewidget.cpp:621
#19 0x000000000077cec3 in CSVDoc::View::addSubView (this=0x294f2e0, id=..., hint="c:#-1 -3")
at /home/marc/OpenMW/openmw/apps/opencs/view/doc/view.cpp:617
#20 0x0000000000815d46 in CSVDoc::View::qt_static_metacall (_o=0x294f2e0, _c=51385376, _id=51385784,
_a=0x6202b70) at /home/marc/OpenMW/build/apps/opencs/view/doc/moc_view.cxx:158
#21 0x00007ffff51c187a in QMetaObject::activate(QObject*, QMetaObject const*, int, void**) ()
from /usr/lib/x86_64-linux-gnu/libQtCore.so.4
#22 0x0000000000816395 in CSVDoc::SubView::focusId (this=<optimised out>, _t1=..., _t2=...)
at /home/marc/OpenMW/build/apps/opencs/view/doc/moc_subview.cxx:117
#23 0x00007ffff51c187a in QMetaObject::activate(QObject*, QMetaObject const*, int, void**) ()
from /usr/lib/x86_64-linux-gnu/libQtCore.so.4
#24 0x0000000000817b65 in CSVWorld::Table::editRequest ([email protected]=0x29db420, _t1=..., _t2="c:#-1 -3")
at /home/marc/OpenMW/build/apps/opencs/view/world/moc_table.cxx:166
#25 0x0000000000787835 in CSVWorld::Table::viewRecord (this=0x29db420)
at /home/marc/OpenMW/openmw/apps/opencs/view/world/table.cpp:577
#26 0x0000000000817d25 in CSVWorld::Table::qt_static_metacall (_o=0x7fffb8efe028, _c=51385376, _id=51385784,
_a=0x6202b70) at /home/marc/OpenMW/build/apps/opencs/view/world/moc_table.cxx:108
#27 0x00007ffff51c187a in QMetaObject::activate(QObject*, QMetaObject const*, int, void**) ()
from /usr/lib/x86_64-linux-gnu/libQtCore.so.4
#28 0x00007ffff56d8a62 in QAction::triggered(bool) () from /usr/lib/x86_64-linux-gnu/libQtGui.so.4
---Type <return> to continue, or q <return> to quit---
#29 0x00007ffff56da433 in QAction::activate(QAction::ActionEvent) () from /usr/lib/x86_64-linux-gnu/libQtGui.so.4
#30 0x00007ffff5b08509 in ?? () from /usr/lib/x86_64-linux-gnu/libQtGui.so.4
#31 0x00007ffff5b0ca39 in ?? () from /usr/lib/x86_64-linux-gnu/libQtGui.so.4
#32 0x00007ffff572e51a in QWidget::event(QEvent*) () from /usr/lib/x86_64-linux-gnu/libQtGui.so.4
#33 0x00007ffff5b1083b in QMenu::event(QEvent*) () from /usr/lib/x86_64-linux-gnu/libQtGui.so.4
#34 0x00007ffff56dee2c in QApplicationPrivate::notify_helper(QObject*, QEvent*) ()
from /usr/lib/x86_64-linux-gnu/libQtGui.so.4
#35 0x00007ffff56e55dd in QApplication::notify(QObject*, QEvent*) () from /usr/lib/x86_64-linux-gnu/libQtGui.so.4
#36 0x000000000060229b in Application::notify (this=<optimised out>, receiver=<optimised out>,
event=<optimised out>) at /home/marc/OpenMW/openmw/apps/opencs/main.cpp:29
#37 0x00007ffff51ad4dd in QCoreApplication::notifyInternal(QObject*, QEvent*) ()
from /usr/lib/x86_64-linux-gnu/libQtCore.so.4
#38 0x00007ffff56e4d93 in QApplicationPrivate::sendMouseEvent(QWidget*, QMouseEvent*, QWidget*, QWidget*, QWidget**, QPointer<QWidget>&, bool) () from /usr/lib/x86_64-linux-gnu/libQtGui.so.4
#39 0x00007ffff5759d1c in ?? () from /usr/lib/x86_64-linux-gnu/libQtGui.so.4
#40 0x00007ffff5759289 in QApplication::x11ProcessEvent(_XEvent*) () from /usr/lib/x86_64-linux-gnu/libQtGui.so.4
#41 0x00007ffff5780b32 in ?? () from /usr/lib/x86_64-linux-gnu/libQtGui.so.4
#42 0x00007ffff1fc6e04 in g_main_context_dispatch () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#43 0x00007ffff1fc7048 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#44 0x00007ffff1fc70ec in g_main_context_iteration () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#45 0x00007ffff51da7be in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) ()
from /usr/lib/x86_64-linux-gnu/libQtCore.so.4
#46 0x00007ffff5780be6 in ?? () from /usr/lib/x86_64-linux-gnu/libQtGui.so.4
---Type <return> to continue, or q <return> to quit---
#47 0x00007ffff51ac0af in QEventLoop::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) ()
from /usr/lib/x86_64-linux-gnu/libQtCore.so.4
#48 0x00007ffff51ac3a5 in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) ()
from /usr/lib/x86_64-linux-gnu/libQtCore.so.4
#49 0x00007ffff5b0f607 in QMenu::exec(QPoint const&, QAction*) () from /usr/lib/x86_64-linux-gnu/libQtGui.so.4
#50 0x000000000078b550 in CSVWorld::Table::contextMenuEvent (this=0x29db420, event=0x7fffffffc7e0)
at /home/marc/OpenMW/openmw/apps/opencs/view/world/table.cpp:155
#51 0x00007ffff572e7e2 in QWidget::event(QEvent*) () from /usr/lib/x86_64-linux-gnu/libQtGui.so.4
#52 0x00007ffff5ad004e in QFrame::event(QEvent*) () from /usr/lib/x86_64-linux-gnu/libQtGui.so.4
#53 0x00007ffff5bdf633 in QAbstractItemView::viewportEvent(QEvent*) ()
from /usr/lib/x86_64-linux-gnu/libQtGui.so.4
#54 0x00007ffff51ad646 in QCoreApplicationPrivate::sendThroughObjectEventFilters(QObject*, QEvent*) ()
from /usr/lib/x86_64-linux-gnu/libQtCore.so.4
#55 0x00007ffff56dee0c in QApplicationPrivate::notify_helper(QObject*, QEvent*) ()
from /usr/lib/x86_64-linux-gnu/libQtGui.so.4
#56 0x00007ffff56e61f8 in QApplication::notify(QObject*, QEvent*) () from /usr/lib/x86_64-linux-gnu/libQtGui.so.4
#57 0x000000000060229b in Application::notify (this=<optimised out>, receiver=<optimised out>,
event=<optimised out>) at /home/marc/OpenMW/openmw/apps/opencs/main.cpp:29
#58 0x00007ffff51ad4dd in QCoreApplication::notifyInternal(QObject*, QEvent*) ()
from /usr/lib/x86_64-linux-gnu/libQtCore.so.4
#59 0x00007ffff5759a40 in ?? () from /usr/lib/x86_64-linux-gnu/libQtGui.so.4
#60 0x00007ffff5759289 in QApplication::x11ProcessEvent(_XEvent*) () from /usr/lib/x86_64-linux-gnu/libQtGui.so.4
#61 0x00007ffff5780b32 in ?? () from /usr/lib/x86_64-linux-gnu/libQtGui.so.4
---Type <return> to continue, or q <return> to quit---
#62 0x00007ffff1fc6e04 in g_main_context_dispatch () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#63 0x00007ffff1fc7048 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#64 0x00007ffff1fc70ec in g_main_context_iteration () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#65 0x00007ffff51da7a1 in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) ()
from /usr/lib/x86_64-linux-gnu/libQtCore.so.4
#66 0x00007ffff5780be6 in ?? () from /usr/lib/x86_64-linux-gnu/libQtGui.so.4
#67 0x00007ffff51ac0af in QEventLoop::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) ()
from /usr/lib/x86_64-linux-gnu/libQtCore.so.4
#68 0x00007ffff51ac3a5 in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) ()
from /usr/lib/x86_64-linux-gnu/libQtCore.so.4
#69 0x00007ffff51b1b79 in QCoreApplication::exec() () from /usr/lib/x86_64-linux-gnu/libQtCore.so.4
#70 0x0000000000601aa5 in runApplication ([email protected]=1, [email protected]=0x7fffffffe128)
at /home/marc/OpenMW/openmw/apps/opencs/main.cpp:76
#71 0x00000000008f4fcb in wrapApplication (
[email protected]=0x601970 <runApplication(int, char**)>, [email protected]=1,
[email protected]=0x7fffffffe128, appName="OpenMW-CS")
at /home/marc/OpenMW/openmw/components/debug/debugging.cpp:97
#72 0x00000000005f3fb3 in main (argc=1, argv=0x7fffffffe128) at /home/marc/OpenMW/openmw/apps/opencs/main.cpp:82
btw. could please file issues for the two other non-blocking problems you found?

User avatar
AnyOldName3
Posts: 1939
Joined: 26 Nov 2015, 03:25

Re: OpenMW 0.45.0

Post by AnyOldName3 » 31 Oct 2018, 13:30

Capostrophic wrote:
31 Oct 2018, 12:45
Yep, I don't see anything wrong logged when I open arbitrary cell views including those with NPCs and creatures save for useless OpenGL warnings which are not connected to actor rendering (I got these even in exterior cells without any actors) whether I run editor directly or with gdb (with or without catching exceptions).

Not sure. Probably.
Probably put these on the tracker if they're not there already. I might get around to them at some point. I know one GL issue in the CS ended up being fixed in the shadows branch just because Scrawl noticed the issue while I was working on the same file and suggested I fixed it there rather than in its own PR.
AnyOldName3, Master of Shadows

Post Reply