Page 17 of 28

Re: OpenMW 0.44.0

Posted: 20 Jun 2018, 11:47
by Starsheep
Zini wrote:
20 Jun 2018, 07:56
Seems the blocker is actually the lack of an MacOS build.
If needed, I can provide with a .dmg for mac if #4424 makes its way to the 0.44 branch.

I built the RC for windows from scratch with the LTO build flag in cmake. I can't reproduce NullCascade's #4445 but if anyone want to give it a try, it's there

Re: OpenMW 0.44.0

Posted: 20 Jun 2018, 16:33
by psi29a
The openmw-44 branch has fixes for MacOS, so that is no longer a blocker for MacOS.

Do we need another round of RCs because of the change in code? The code path shouldn't technically be touched unless using OSG => 3.5.8 or MacOS

Re: OpenMW 0.44.0

Posted: 20 Jun 2018, 16:41
by Zini
"technically". Yeah, I heard that one before. Let's not take risks. One more round, please. Its not as if we are in a hurry. The ETA for the release video is still +2 weeks anyway.

Edit:

New issue on the tracker: Bug #4424

Re: OpenMW 0.44.0

Posted: 20 Jun 2018, 18:31
by Starsheep
psi29a wrote:
20 Jun 2018, 16:33
The openmw-44 branch has fixes for MacOS, so that is no longer a blocker for MacOS.
Thank you.

Putting there my build settings in case I made a mistake. It's not like I'm building MacOs apps everyday so please let me know if something's wrong:

cmake and pkg-config homebrewed.
OpenMW-deps-Mac built from scratch
Qt5.5 installed from the package from the Qt project site, not homebrewed.

cmake script with arguments:

Code: Select all

#!/bin/sh

export CXX=clang++
export CC=clang

DEPENDENCIES_ROOT="/Users/stephane/Dev/openmw-deps-mac/build/openmw-deps"
QT_PATH="/Users/stephane/Qt5.5.1/5.5/clang_64/lib/cmake"
cd ..
cd build

cmake \
-D CMAKE_PREFIX_PATH="$DEPENDENCIES_ROOT;$QT_PATH" \
-D CMAKE_OSX_DEPLOYMENT_TARGET="10.9" \
-D CMAKE_OSX_SYSROOT="macosx10.13" \
-D CMAKE_BUILD_TYPE=Release \
-D OPENMW_OSX_DEPLOYMENT=TRUE \
-D DESIRED_QT_VERSION=5 \
-D BUILD_ESMTOOL=FALSE \
-D BUILD_MYGUI_PLUGIN=FALSE \
-G"Unix Makefiles" \
..
btw, the dev environment setup wiki page states a -D CMAKE_BUILD_TYPE=Debug \ in the deployment section. Mistake?
Also, -D CMAKE_CXX_FLAGS="-stdlib=libstdc++" \ argument has been omitted since make wasn't happy with it last time I built the project. Can't remember why though.


the 0.44-RC1 .dmg file is there

The fix to #4424 works and the cursor is no longer upside down, so the OPENMW_CURSOR_WORKAROUND environment variable doesn't seem necessary anymore. At least here.

Re: OpenMW 0.44.0

Posted: 20 Jun 2018, 18:53
by corristo

Re: OpenMW 0.44.0

Posted: 20 Jun 2018, 18:56
by corristo
@Starsheep

The wiki section is a bit dated, unfortunately. -D CMAKE_CXX_FLAGS="-stdlib=libstdc++" is no longer needed, correct.
-D CMAKE_BUILD_TYPE=Debug was a mistake, indeed.

When in doubt, please refer to the CI configuration: https://github.com/OpenMW/openmw/blob/2 ... sh#L11-L21 (I'm currently updating it to build using macOS 10.13 SDK).

I'm really happy to see someone taking over the building!

UPD you're right, the environment variable is no longer necessary, actually its support has been completely removed from the code.

Re: OpenMW 0.44.0

Posted: 20 Jun 2018, 19:40
by Starsheep
My pleasure,
Redundancy can't be a bad thing in our case.

update: wiki edited

Re: OpenMW 0.44.0

Posted: 20 Jun 2018, 19:51
by raevol
Current Release Status updated here

Re: OpenMW 0.44.0

Posted: 20 Jun 2018, 19:54
by Capostrophic
raevol, Linux and Windows RCs should actually be rebuilt.

Re: OpenMW 0.44.0

Posted: 20 Jun 2018, 20:55
by Ace (SWE)
New line of RCs, these ones built without LTO to see if that helps NullCascade's issue.

32-bit
64-bit