OpenMW 0.41.0

[raevol]

I agree these issues should be fixed for 0.41.0, but that's a call we should leave to zini. I'm still picking away at the changelog, this stuff is rough to get through.

[Zini]

The question is do we have anyone with enough time to work on this? We are kinda running out of time here and unless we find a volunteer immediately we would probably have to move the release to next year. If we do not have a volunteer is that something we are willing to do?

Anyway, do we have anyone with a bit of free time and the ability to build OpenMW from source? You don't have to be a coder to do a git bisect and if we know which commit caused the problem that would increase our chances to fix the problem in time (or at least add a workaround).

[cc9cii]

I can't build the master branch but I would probably start by looking at canFight() in 7f27e529bbf784aae473e57352b0bf39d5c16f79

[MiroslavR]

I can't build the master branch but I would probably start by looking at canFight() in 7f27e529bbf784aae473e57352b0bf39d5c16f79

I remember this being an issue way before I implemented canFight(). I haven't tested, but I believe Allofich may have found the offending commit here: https://github.com/OpenMW/openmw/pull/1 ... -264912114. I can see that the PR removes a line of sight check in the AiCombat package.

[Allofich]

Yeah as I noted in that PR, the commit immediately before that PR is merged does not have the problem, while the merging commit does have it, so I'm pretty sure that the problem is there.

[Zini]

Good. And we now also have devs in this thread who worked on this particular code. Anyone willing to try setting up a quick fix?

[psi29a]

@Zini: https://github.com/OpenMW/openmw/pull/1148

[scrawl]

Thanks to Allofich for the 2 quick fixes, now in master and openmw-41.

Please build new RCs for the (hopefully) final round of testing.

[Atahualpa]

Allofich for president! (And MiroslavR too.)

[Aussiemon]

I'm getting "Unhandled controller NiPathController on node 90 in meshes/e/magic_cast_myst.nif" and "Unhandled SDL event of type 0x302" errors in a fresh build (deleted source files, cloned, and rebuilt) with the recent commits. Windows 8.1 x64. Built with VS2015. I"m not sure if the first error is a Vanilla problem (the spell was soul trap), but the second is definitely new.

I'm going to try another rebuild and see if they still occur.

Full log: http://pastebin.com/P296B4Lg

Edit: Still happening after another fresh build.

New log: http://pastebin.com/iANkrufk

Edit2: Okay, it might've been a problem with my CMake settings. Not seeing the unhandled SDL bug after messing with directories. Soul trap NiPathController bug is still present, but still not sure if it's a Vanilla problem. I'll keep testing and see if I spot anything else.