OpenMW 0.36.0

[Ace (SWE)]

More Windows RCs:

32-bit
64-bit

[psi29a]

OpenMW 0.36 RC2 Ubuntu Vivid x86_64:
https://dl.dropboxusercontent.com/u/396 ... 64.tar.bz2

[K1ll]

OpenMW 0.36.0 RC2 Linux targz packages:

32 Bit
64 Bit

[scrawl]

With the last-minute-fix branch merged, these need to be added to the changelog:

https://bugs.openmw.org/issues/2521
https://bugs.openmw.org/issues/1405
https://bugs.openmw.org/issues/2530
https://bugs.openmw.org/issues/2525
https://bugs.openmw.org/issues/2518
https://bugs.openmw.org/issues/2519

Scrawl do you want your name capitalized in the announcement?

Lower-case please.

[raevol]

Changelog updated: https://gist.github.com/mickeylyle/1046f9a5e391b6599bb8

Please please check for errors.

@wareya I couldn't figure out how to "merge" your revision, so I had to just copy/paste it in. Sorry.

[corristo]

RC2 for OS X:
http://downloads.openmw.org/osx/OpenMW-0.36.0-rc2.dmg

@HiPhish
Launch OpenCS, open cell list, select a cell and use context menu to open render window. It could crash instantly, or you may have to zoom/fly around a bit to trigger crash.

[cc9cii]

Not sure if this is a blocker, but certainly warrants a mention as a known issue. Delete record in Objects table seems to mess up other records. https://bugs.openmw.org/issues/2545

EDIT: this issue's been around at least 6 months and probably longer, without anyone noticing, so on that basis perhaps not a blocker after all

[HiPhish]

The installer wizard does not work on OS X: I wiped my preferences (~/Library/Preferences/openmw/) and when I am asked whether to launch the wizard I say yes and the whole thing crashes. What should I post?

EDIT: without wiping my preferences OpenMW works fine, but the CS won't even start, that's why I wanted to wipe them.

[Zini]

@cc9cii: Saving deleted records doesn't work properly anyway, so we actually do not lose anything because of this bug. Definitely not a blocker.

[corristo]

@HiPhish
Could you send me your preferences please?
I'll look into importer crash, thanks.

Okay, I'm getting EXC_BAD_ACCESS here as well, settingspage.cpp

Code: Select all

   229 	void Launcher::SettingsPage::resetProgressBar()
   230 	{
   231 	    // set progress bar to 0 %
-> 232 	    progressBar->reset();
   233 	}

Can anyone with Qt experience look into it to check what can cause this?

Full stacktrace:

Spoiler: Show

Code: Select all

* thread #1: tid = 0x2cb9d0, 0x0000000100022550 openmw-launcher`Launcher::SettingsPage::resetProgressBar(this=0x0000000000000000) + 16 at settingspage.cpp:232, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0xc0)
  * frame #0: 0x0000000100022550 openmw-launcher`Launcher::SettingsPage::resetProgressBar(this=0x0000000000000000) + 16 at settingspage.cpp:232
    frame #1: 0x000000010001c1d6 openmw-launcher`Launcher::MainDialog::changePage(this=0x00007fff5fbff7d8, current=0x000000010b406d30, previous=0x0000000000000000) + 102 at maindialog.cpp:243
    frame #2: 0x0000000100029936 openmw-launcher`Launcher::MainDialog::qt_static_metacall(_o=0x00007fff5fbff7d8, _c=InvokeMetaMethod, _id=0, _a=0x00007fff5fbfe290) + 182 at moc_maindialog.cxx:54
    frame #3: 0x0000000101ac2c2e QtCore`QMetaObject::activate(QObject*, QMetaObject const*, int, void**) + 1566
    frame #4: 0x000000010127deed QtGui`QListWidget::currentItemChanged(QListWidgetItem*, QListWidgetItem*) + 61
    frame #5: 0x0000000101280316 QtGui`QListWidgetPrivate::_q_emitCurrentItemChanged(QModelIndex const&, QModelIndex const&) + 150
    frame #6: 0x0000000101ac2c2e QtCore`QMetaObject::activate(QObject*, QMetaObject const*, int, void**) + 1566
    frame #7: 0x000000010126a0ed QtGui`QItemSelectionModel::currentChanged(QModelIndex const&, QModelIndex const&) + 45
    frame #8: 0x000000010126a21e QtGui`QItemSelectionModel::setCurrentIndex(QModelIndex const&, QFlags<QItemSelectionModel::SelectionFlag>) + 142
    frame #9: 0x000000010120ff82 QtGui`QAbstractItemView::focusInEvent(QFocusEvent*) + 530
    frame #10: 0x0000000100d60fdc QtGui`QWidget::event(QEvent*) + 1452
    frame #11: 0x00000001010f73ac QtGui`QFrame::event(QEvent*) + 44
    frame #12: 0x0000000101184e9b QtGui`QAbstractScrollArea::event(QEvent*) + 123
    frame #13: 0x0000000101213bfb QtGui`QAbstractItemView::event(QEvent*) + 139
    frame #14: 0x000000010122e199 QtGui`QListView::event(QEvent*) + 9
    frame #15: 0x000000010127e0d9 QtGui`QListWidget::event(QEvent*) + 9
    frame #16: 0x0000000100d09b0d QtGui`QApplicationPrivate::notify_helper(QObject*, QEvent*) + 189
    frame #17: 0x0000000100d0dd68 QtGui`QApplication::notify(QObject*, QEvent*) + 232
    frame #18: 0x0000000101aaa54c QtCore`QCoreApplication::notifyInternal(QObject*, QEvent*) + 124
    frame #19: 0x0000000100d10781 QtGui`QApplicationPrivate::setFocusWidget(QWidget*, Qt::FocusReason) + 705
    frame #20: 0x0000000100d56ac7 QtGui`QWidget::setFocus(Qt::FocusReason) + 311
    frame #21: 0x0000000100d11bb5 QtGui`QApplication::setActiveWindow(QWidget*) + 1093
    frame #22: 0x0000000100c968ec QtGui`onApplicationWindowChangedActivation(QWidget*, bool) + 92
    frame #23: 0x0000000100cb5bf1 QtGui`-[QCocoaWindowDelegate windowDidBecomeKey:] + 65
    frame #24: 0x00007fff91b3945c CoreFoundation`__CFNOTIFICATIONCENTER_IS_CALLING_OUT_TO_AN_OBSERVER__ + 12
    frame #25: 0x00007fff91a29634 CoreFoundation`_CFXNotificationPost + 3140
    frame #26: 0x00007fff89c849d1 Foundation`-[NSNotificationCenter postNotificationName:object:userInfo:] + 66
    frame #27: 0x00007fff8d4d2bd9 AppKit`-[NSWindow becomeKeyWindow] + 1406
    frame #28: 0x00007fff8d4d1f3e AppKit`-[NSWindow _changeKeyAndMainLimitedOK:] + 795
    frame #29: 0x00007fff8d4d1b36 AppKit`-[NSWindow _makeKeyRegardlessOfVisibility] + 98
    frame #30: 0x00007fff8d4d1a9e AppKit`-[NSWindow makeKeyAndOrderFront:] + 27
    frame #31: 0x0000000100ca7923 QtGui`QWidgetPrivate::show_sys() + 1123
    frame #32: 0x0000000100d64328 QtGui`QWidgetPrivate::show_helper() + 408
    frame #33: 0x0000000100d6465f QtGui`QWidget::setVisible(bool) + 511
    frame #34: 0x000000010001692b openmw-launcher`QWidget::show(this=0x00007fff5fbff7d8) + 27 at qwidget.h:497
    frame #35: 0x00000001000165e8 openmw-launcher`main(argc=1, argv=0x00007fff5fbffa08) + 1336 at main.cpp:69
    frame #36: 0x0000000100003a44 openmw-launcher`start + 52

UPD: got it, mSettingsPage is NULL in frame #1 for some reason.

Ok, I found why it's NULL, but have no idea how to fix this without ugly hacks or introducing additional state like "bool mIsSetup" into MainDialog.

If wizard message box is presented, MainDialog::setup will not run until wizard is finished. It seems that Qt fires MainDialog::changePage event when launcher window receives focus ("becomes key window" in OS X terms) *after* wizard message box dismissal but obviously before wizard is complete (i.e. before MainDialog::setup is run).