Script questions

General discussion regarding the OpenMW project.
For technical support, please use the Support subforum.
Post Reply
Tinker
Posts: 231
Joined: 06 Mar 2013, 17:35

Script questions

Post by Tinker »

I am currently testing / retesting Abot's water life and birds mods.

ab01wlcrShipWreckScript from water life throws a verify error on line 73, column 0 (<newline>): missing expression.

lines 70 - 73 are

Code: Select all

if ( ab01debug == 2 )
	MessageBox "shipwreck N. %g scale set to %f" ab01wlShipWrecks
endif
Is this a script error or a bug?

The sea star, shells and sandcoin scripts seem to not work correctly, the scripts are similar for the harvesting section

Code: Select all

if ( OnActivate )
	if ( ab01autoLoot == 0 )
		; set t2 to 0
		; disable
		activate
		return		
	else
		set x1 to ( ( player->GetLuck ) + 20 )
		set i1 to Random 101
		if ( x1 > i1 )
			if ( GetItemCount "ab01wlRndSandCoin01" > 0 )
				player->AddItem ab01ingred_sandCoin01 1
			elseif ( GetItemCount "ab01wlRndSandCoin02" > 0 )
				player->AddItem ab01ingred_sandCoin02 1
			elseif ( GetItemCount "ab01wlRndSandCoin03" > 0 )
				player->AddItem ab01ingred_sandCoin03 1
			elseif ( GetItemCount "ab01wlRndSandCoin04" > 0 )
				player->AddItem ab01ingred_sandCoin04 1
			elseif ( GetItemCount "ab01wlRndSandCoin05" > 0 )
				player->AddItem ab01ingred_sandCoin05 1
			elseif ( GetItemCount "ab01wlRndSandCoin06" > 0 )
				player->AddItem ab01ingred_sandCoin06 1
			elseif ( GetItemCount "ab01wlRndSandCoin07" > 0 )
				player->AddItem ab01ingred_sandCoin07 1
			elseif ( GetItemCount "ab01wlRndSandCoin08" > 0 )
				player->AddItem ab01ingred_sandCoin08 1
			else
				set i1 to -1
			endif
			if ( i1 >= 0 )
				MessageBox "Sand Coin gathered"
			endif
		else
			MessageBox "No luck this time"
		endif
Occasionally the 'No luck" message is displayed showing the script is doing something but no sand stars, shells or coins are added to the inventory, I am not sure if this is a script error or bug either.

There is another entry in the error log

Code: Select all

NIFSkeletonLoader: Warn: Unhandled NiDirectionalLight __MAX_Default_Light in meshes\abot\ab01fishingrod.nif
should this be added as a bug?

Both mods throw loads of errors for missing attack or idle animations in many models but I am not sure how to test if the animations are missing or a bug in OpenMW is preventing them from running. As both these mods have been run extensively in vanilla there seems to be a difference in the way that OpenMW deals with them.
User avatar
Zini
Posts: 5538
Joined: 06 Aug 2011, 15:16

Re: Script questions

Post by Zini »

Is this a script error or a bug?
Defective script. The message box text takes 2 parameters, but only one (ab01wlShipWrecks) is given.
The sea star, shells and sandcoin scripts seem to not work correctly, the scripts are similar for the harvesting section
I don't see any bug in this script. Maybe something else is going wrong somewhere.
NIFSkeletonLoader: Warn: Unhandled NiDirectionalLight __MAX_Default_Light in meshes\abot\ab01fishingrod.nif
Apparently a property of the NIF format that we do not handle yet. Please file a bug report.
User avatar
scrawl
Posts: 2152
Joined: 18 Feb 2012, 11:51

Re: Script questions

Post by scrawl »

Zini wrote:
NIFSkeletonLoader: Warn: Unhandled NiDirectionalLight __MAX_Default_Light in meshes\abot\ab01fishingrod.nif
Apparently a property of the NIF format that we do not handle yet. Please file a bug report.
I don't think there's any valid use for directional lights defined in a NIF file. The name __MAX_Default_Light also suggests that it was left in there by accident. Does the original engine actually use such lights?
Tinker
Posts: 231
Joined: 06 Mar 2013, 17:35

Re: Script questions

Post by Tinker »

Bug opened for NIF problem just so it does not get lost.

Other problems passed to mod author.
User avatar
psi29a
Posts: 5361
Joined: 29 Sep 2011, 10:13
Location: Belgium
Gitlab profile: https://gitlab.com/psi29a/
Contact:

Re: Script questions

Post by psi29a »

Also found in Ashes of Apocalypse:
NIFSkeletonLoader: Warn: Unhandled NiDirectionalLight __MAX_Default_Light in meshes\lv-01\chair_blue.nif
NIFSkeletonLoader: Warn: Unhandled NiDirectionalLight __MAX_Default_Light in meshes\lv-01\chair_blue.nif
NIFSkeletonLoader: Warn: Unhandled NiDirectionalLight __MAX_Default_Light in meshes\ig-85\splat.nif
NIFSkeletonLoader: Warn: Unhandled NiDirectionalLight __MAX_Default_Light in meshes\ig-85\splat.nif
NIFSkeletonLoader: Warn: Unhandled NiDirectionalLight __MAX_Default_Light in meshes\bx-99\trash.nif
NIFSkeletonLoader: Warn: Unhandled NiDirectionalLight __MAX_Default_Light in meshes\bx-99\trash.nif
Post Reply