OpenMW 0.45.0

Anything related to PR, release planning and any other non-technical idea how to move the project forward should be discussed here.
User avatar
Capostrophic
Posts: 455
Joined: 22 Feb 2016, 20:32

Re: OpenMW 0.45.0

Post by Capostrophic » 08 Nov 2018, 12:20

:(
With all due respect, please reconsider. Even without considering the nice round number of 200 in decimal numeric system, if NPC rendering is not an important future, I don't know what is, the RC phase hasn't even really started yet, and I'm pretty sure the existing dirty fix as it is could be considered an intentional regression, as you could at least see the NPCs as white shapes (IIRC) in previous releases and now you cannot. And AFAIK creatures are actually not affected by the hotfix, so the feature is not "disabled" per se, just dropped in in a "half-baked" state.
shitty lingua anglica grammar ftw

User avatar
psi29a
Posts: 4274
Joined: 29 Sep 2011, 10:13
Github profile: https://github.com/psi29a/
Contact:

Re: OpenMW 0.45.0

Post by psi29a » 08 Nov 2018, 12:56

@Zini: I don't believe this to be an issue. It's why we have RCs to begin with. Just means we can cherry-pick this and move on to RC2 :)

User avatar
Capostrophic
Posts: 455
Joined: 22 Feb 2016, 20:32

Re: OpenMW 0.45.0

Post by Capostrophic » 08 Nov 2018, 14:55

Sorry, that was me overreacting.

I'd welcome any suggestions regarding the changelog now, I'd rather not rewrite it from scratch in full because it was deeply flawed once I no longer have access to my usual PC for the rest of November.
shitty lingua anglica grammar ftw

User avatar
akortunov
Posts: 435
Joined: 13 Mar 2017, 13:49
Location: Samara, Russian Federation
Github profile: https://github.com/akortunov

Re: OpenMW 0.45.0

Post by akortunov » 09 Nov 2018, 10:29

A bit offtopic, but it seems we have no topic for 0.46 yet.
Since we merged some quite large PRs recently (recastnavigation, weapon sheathing, changes in the FFMpeg API), I suppose we need to run a Coverity Scan again.
Also probably we should exclude the extern/recastnavigation folder from Coverity Scan since there will be a lot of complaints about issues, not related to OpenMW.

User avatar
psi29a
Posts: 4274
Joined: 29 Sep 2011, 10:13
Github profile: https://github.com/psi29a/
Contact:

Re: OpenMW 0.45.0

Post by psi29a » 09 Nov 2018, 11:20

I've added recastnavigation as a component we ignore, that's been taken care of.

merged master into coverity_scan, report inbound...

https://travis-ci.org/OpenMW/openmw/bui ... tification

User avatar
psi29a
Posts: 4274
Joined: 29 Sep 2011, 10:13
Github profile: https://github.com/psi29a/
Contact:

Re: OpenMW 0.45.0

Post by psi29a » 09 Nov 2018, 12:34

Grumble... so while the build is green, coverity complains with:
Last Build Status: Failed. Your build has failed due to the following reason. Please fix the error and upload the build again.
Error details: The build uploaded has not been fully compiled. Please fix all compilation errors for accurate analysis.
I'm heading out for the weekend so hopefully someone else can figure this out. I'll look back into it Monday.

Cheers

User avatar
Zini
Posts: 5531
Joined: 06 Aug 2011, 15:16

Re: OpenMW 0.45.0

Post by Zini » 09 Nov 2018, 13:42

@Capostrophic: To clarify: Of course NPC rendering in the scene is important. However my position on OpenMW-CS is that is still only a tech demo at this stage (some parts more so than others). Therefore the big red alpha warning on startup.

The 3D scene in particular is very rough with core features still missing and (maybe more importantly) several usability features either being incomplete or completely missing, which results in abysmal usability. There may be a few brave souls who venture forth and try to use scene editing, but they do that at their own peril. I do not consider the 3D scene editing functions ready for practical use. Therefore IMO moving this feature to 0.46 has little impact and thus it is not very important for 0.45.

Still, I have tested the fix now and it seems to work. If we end up having a second round of RC builds and people really want this feature in (200 issues an all), I won't veto it.

User avatar
Atahualpa
Posts: 909
Joined: 09 Feb 2016, 20:03

Re: OpenMW 0.45.0

Post by Atahualpa » 09 Nov 2018, 20:36

FYI: The release commentaries are nowhere near finished, so take your time...

User avatar
ap0
Posts: 275
Joined: 11 Aug 2011, 18:47
Contact:

Re: OpenMW 0.45.0

Post by ap0 » 10 Nov 2018, 00:59

@akortunov it would be nice to suggest to the recastnavigation people to use coverity in their CI; since apparently coverity has some complains about it :P

User avatar
akortunov
Posts: 435
Joined: 13 Mar 2017, 13:49
Location: Samara, Russian Federation
Github profile: https://github.com/akortunov

Re: OpenMW 0.45.0

Post by akortunov » 10 Nov 2018, 05:11

ap0 wrote:
10 Nov 2018, 00:59
@akortunov it would be nice to suggest to the recastnavigation people to use coverity in their CI; since apparently coverity has some complains about it :P
They already use it.
Last edited by akortunov on 12 Nov 2018, 11:54, edited 1 time in total.

Post Reply

Who is online

Users browsing this forum: No registered users and 5 guests