Version/Build number in Launcher window

[Greendogo]

It looks good except that "... unstable, revision ..." seems a little busy.

On second thought, your previous implementation was much cleaner:

Spoiler: Show

It might look even cleaner if you wrote the revision in parenthesis instead of writing "revision", like this:
OpenMW 0.28.0 (fa186f5ec1)

What do others think?

[nnayo]

parenthesis seems a nice idea

[pvdk]

What about:

Code: Select all

OpenMW unstable (fa186f5ec1)

[Zini]

Actually, I don't like the word unstable. It indicates that the build is ... well unstable, which is not necessarily the case. Can we either find a better description or just leave it out with the lack of a release number indicating that it is not a proper release, e.g.: OpenMW (fa186f5ec1) ?

As for automatically detecting the difference between a release build and a non-release build: We could add a cmake variable for that:

set (OPENMW_RELEASE_BUILD 0)

I would then set the value to 1 immediately before release tagging and set the value back to 0 after the release.

An alternative would be a cmake option.

option (BUILD_RELEASE "this is a release build" OFF)

But then all package manager would have to remember adjust their CMakeCache files before and after releases (or use a different cache file for releases).

[psi29a]

Why do that? Use the power of cmake...

if CMAKE_BUILD_TYPE == Release ...

by default, CMAKE_BUILD_TYPE is set to Debug unless you specify Release in your cmake flags.

[scrawl]

pvdk already found a better solution. Just checking if the current revision is a release tag. No manual intervention required

[Lazaroth]

Would it be completely wrong calling it a 0.29 alpha, thereby avoiding the "unstable" label while still making it clear what it is?

[psi29a]

Release and Debug/Development... it should be obvious what each means.

[pvdk]

What about:

Spoiler: Show

The code works on Mac OS X now, and it should work on Windows too. I'll send a pull request if the text as seen in the screenshot is okay.

[Zini]

Looks okay to me.