Page 8 of 38

Re: OpenMW 0.45.0

Posted: 20 Oct 2018, 03:52
by terabyte25

Re: OpenMW 0.45.0

Posted: 20 Oct 2018, 03:58
by terabyte25

Re: OpenMW 0.45.0

Posted: 20 Oct 2018, 09:14
by Zini
@Atahualpa We are going ahead with the release. We just need to fix this one last blocker and then I will start the RC phase.

Re: OpenMW 0.45.0

Posted: 20 Oct 2018, 09:59
by raevol
Haha, well that's what happens when someone who writes the code does the changelog I guess. :)

Re: OpenMW 0.45.0

Posted: 23 Oct 2018, 20:15
by akortunov
terabyte25 wrote: 20 Oct 2018, 03:30 Okay, so I tried looking for when this appeared, and it appeared all the way back in late June. It started when macOS support was broken (OpenMW client didn't launch) June 20th(OpenMW-20062018-22eb037) all the way to June 28th(OpenMW-28062018-f07d50e). I believe it was the either the commit that broke macOS support, or the commit that fixed macOS support that caused this regression to pop up.
Weird. It this period there were a lot of CI and dependency changes.
For example, we started to use the 10.13 SDK for Mac OS.
I suppose we need an actual bisect to find out what exactly causes the issue.

Re: OpenMW 0.45.0

Posted: 24 Oct 2018, 00:03
by terabyte25
akortunov wrote: 23 Oct 2018, 20:15
terabyte25 wrote: 20 Oct 2018, 03:30 Okay, so I tried looking for when this appeared, and it appeared all the way back in late June. It started when macOS support was broken (OpenMW client didn't launch) June 20th(OpenMW-20062018-22eb037) all the way to June 28th(OpenMW-28062018-f07d50e). I believe it was the either the commit that broke macOS support, or the commit that fixed macOS support that caused this regression to pop up.
Weird. It this period there were a lot of CI and dependency changes.
For example, we started to use the 10.13 SDK for Mac OS.
I suppose we need an actual bisect to find out what exactly causes the issue.
What would be the best commit to check first?

Also I am having problems with compiling in macOS in the meantime, I'll see to it I get it compiling correctly.

Re: OpenMW 0.45.0

Posted: 26 Oct 2018, 09:04
by akortunov
It seems weapon condition indicator is broken.

Re: OpenMW 0.45.0

Posted: 26 Oct 2018, 10:00
by akortunov
Probably an another regression: https://gitlab.com/OpenMW/openmw/issues/4694

Re: OpenMW 0.45.0

Posted: 26 Oct 2018, 10:07
by wareya
That might be specific to whatever Bullet build the OpenMW OSX nightlies are being compiled against.

Re: OpenMW 0.45.0

Posted: 26 Oct 2018, 11:08
by akortunov
wareya wrote: 26 Oct 2018, 10:07 That might be specific to whatever Bullet build the OpenMW OSX nightlies are being compiled against.
Or more likely it is just a regression in this commit.