Need help testing PR #1594, which fixes controller issues

Everything about development and the OpenMW source code.
User avatar
Thunderforge
Posts: 489
Joined: 06 Jun 2017, 05:57
Github profile: https://github.com/Thunderforge

Need help testing PR #1594, which fixes controller issues

Post by Thunderforge » 08 Jan 2018, 04:04

PR #1594 should fix a number of controller issues that people are having. Unfortunately, scrawl doesn't own a controller and has asked if there is anyone who owns a controller that can test this PR.

I have a controller that wasn't working and now is (Xbox One Bluetooth via macOS). However, scarwl would especially like to know if there is anyone who has a controller that is currently working to make sure that it is still working after this PR.

Even if you don't have that specific case, any help with testing this would be greatly appreciated.

magamo
Posts: 105
Joined: 28 May 2016, 17:28

Re: Need help testing PR #1594, which fixes controller issues

Post by magamo » 08 Jan 2018, 12:37

Works perfectly fine with my DualShock 4 under linux, all controller buttons map and work as expected.

User avatar
wareya
Posts: 218
Joined: 09 May 2015, 13:07

Re: Need help testing PR #1594, which fixes controller issues

Post by wareya » 08 Jan 2018, 22:39

I can test it once it's merged and a nightly incorporates it.
paying attention to #1751/#1816 #2473 #3609 #3862/#3929 #3807 #4297

User avatar
Thunderforge
Posts: 489
Joined: 06 Jun 2017, 05:57
Github profile: https://github.com/Thunderforge

Re: Need help testing PR #1594, which fixes controller issues

Post by Thunderforge » 10 Jan 2018, 05:13

wareya wrote:
08 Jan 2018, 22:39
I can test it once it's merged and a nightly incorporates it.
Looks like it got merged yesterday, so it should be in the most recent nightlies. Let us know how it turns out!

User avatar
Ravenwing
Posts: 232
Joined: 02 Jan 2016, 02:51

Re: Need help testing PR #1594, which fixes controller issues

Post by Ravenwing » 10 Jan 2018, 07:52

I tested my controller briefly with the latest nightly. It's an xbox 360 controller and worked as well as it ever has in OpenMW. This is on Windows 10 though, are you only concerned with macOS? I haven't used a controller in ages due to the lack of a proper GUI for them in OpenMW, but the right joystick seemed easier to control than I remember. Were any modifications made to the speed or acceleration?

User avatar
Thunderforge
Posts: 489
Joined: 06 Jun 2017, 05:57
Github profile: https://github.com/Thunderforge

Re: Need help testing PR #1594, which fixes controller issues

Post by Thunderforge » 10 Jan 2018, 17:06

A number of configuration files originally from the SDL_GameControllerDB project were updated in OpenMW. This included new controller mappings, fixes for newer versions of SDL, and other improvements affecting all platforms. I think that macOS had the most to gain from these updates, but other platforms probably see benefits as well. I’m not aware of any specific improvements to acceleration, but if it’s better than before, I think we’ll call that a win.

User avatar
wareya
Posts: 218
Joined: 09 May 2015, 13:07

Re: Need help testing PR #1594, which fixes controller issues

Post by wareya » 10 Jan 2018, 19:55

Thunderforge wrote:
10 Jan 2018, 05:13
Looks like it got merged yesterday, so it should be in the most recent nightlies. Let us know how it turns out!
Still waiting on the nightly to update from b86118f76
paying attention to #1751/#1816 #2473 #3609 #3862/#3929 #3807 #4297

User avatar
Thunderforge
Posts: 489
Joined: 06 Jun 2017, 05:57
Github profile: https://github.com/Thunderforge

Re: Need help testing PR #1594, which fixes controller issues

Post by Thunderforge » 12 Jan 2018, 03:21

wareya wrote:
10 Jan 2018, 19:55
Thunderforge wrote:
10 Jan 2018, 05:13
Looks like it got merged yesterday, so it should be in the most recent nightlies. Let us know how it turns out!
Still waiting on the nightly to update from b86118f76
The fix works for me in b86118f76 on macOS.

User avatar
wareya
Posts: 218
Joined: 09 May 2015, 13:07

Re: Need help testing PR #1594, which fixes controller issues

Post by wareya » 12 Jan 2018, 04:50

That commit should be too old to have the PR. Is that what commit it says it is in-game, or is it the one from the image in the nightly's OP?
paying attention to #1751/#1816 #2473 #3609 #3862/#3929 #3807 #4297

User avatar
Thunderforge
Posts: 489
Joined: 06 Jun 2017, 05:57
Github profile: https://github.com/Thunderforge

Re: Need help testing PR #1594, which fixes controller issues

Post by Thunderforge » 15 Jan 2018, 00:52

It says "OpenMW development (b86118f76f)" in the Launcher. Regardless, the point is probably moot, given that there are now newer nightlies that surely have it.

Post Reply

Who is online

Users browsing this forum: No registered users and 5 guests