[Resolved] Splash screen only accepted in TGA format.

Feedback on past, current, and future development.
User avatar
kuyondo
Posts: 115
Joined: 29 Mar 2016, 17:45

[Resolved] Splash screen only accepted in TGA format.

Post by kuyondo » 13 Sep 2017, 09:24

TGA files are large, maybe we can use DDS as an alternative? OpenMW only accepts TGA formats for splashscreens. DDS has smaller file size and keeps the same quality. What do you think of this?

User avatar
psi29a
Posts: 3432
Joined: 29 Sep 2011, 10:13
Github profile: https://github.com/psi29a/
Contact:

Re: Splash screen only accepted in TGA format.

Post by psi29a » 13 Sep 2017, 10:40

Create a issue on the bug tracker... so we can track it. :D

If you know how to code, please create a PR. :)

User avatar
psi29a
Posts: 3432
Joined: 29 Sep 2011, 10:13
Github profile: https://github.com/psi29a/
Contact:

Re: Splash screen only accepted in TGA format.

Post by psi29a » 13 Sep 2017, 12:54

Nevermind... does this help?

https://github.com/OpenMW/openmw/pull/1452

Add supported for dds and png.

We can always add more, or if someone has a way to poll OSG for supported formats... I could use that instead of a custom list.

User avatar
AnyOldName3
Posts: 546
Joined: 26 Nov 2015, 03:25

Re: Splash screen only accepted in TGA format.

Post by AnyOldName3 » 13 Sep 2017, 13:33

At the minimum, I'm pretty sure you can query OSG about which plugins it has available. Using this, you could then have a map from plugin name to supported formats, and for each plugin installed, add its associated formats to the search list.

JohnMaster
Posts: 30
Joined: 09 Aug 2017, 05:32

Re: Splash screen only accepted in TGA format.

Post by JohnMaster » 13 Sep 2017, 13:41


User avatar
scrawl
Posts: 2076
Joined: 18 Feb 2012, 11:51
Contact:

Re: Splash screen only accepted in TGA format.

Post by scrawl » 13 Sep 2017, 13:48

The deal with using the list of OSG's supported formats is that the list depends on how the user compiled OSG. Now imagine user A's build supports some obscure format, he makes a splashscreen in said format, uploads it as a mod and now other users will complain they can't use it.

I'd say we limit ourselves to the list of recommended formats from here. (dds, tga, bmp, jp[e]g, png)

User avatar
psi29a
Posts: 3432
Joined: 29 Sep 2011, 10:13
Github profile: https://github.com/psi29a/
Contact:

Re: Splash screen only accepted in TGA format.

Post by psi29a » 13 Sep 2017, 14:28

I'll add the additional formats you listed scrawl, thanks. (bmp, jpeg, jpg)

We can always expand the list if there is some overwhelming reason to do so.

I'm on the bench about ktx...

Chris
Posts: 1286
Joined: 04 Sep 2011, 08:33

Re: Splash screen only accepted in TGA format.

Post by Chris » 14 Sep 2017, 01:12

psi29a wrote:
13 Sep 2017, 14:28
I'm on the bench about ktx...
I'd say go for it, as long as OSG's support for it isn't flaky. Always good to support open format alternatives to proprietary DirectX-centric ones, IMO.

User avatar
psi29a
Posts: 3432
Joined: 29 Sep 2011, 10:13
Github profile: https://github.com/psi29a/
Contact:

Re: Splash screen only accepted in TGA format.

Post by psi29a » 14 Sep 2017, 09:19

It was merged, so this feature request should be resolved now. ;)

I added ktx as well.

Thanks kuyondo for bringing this up.

User avatar
kuyondo
Posts: 115
Joined: 29 Mar 2016, 17:45

Re: [Resolved] Splash screen only accepted in TGA format.

Post by kuyondo » 14 Sep 2017, 14:22

Excellent work psi, maybe trivial but very good for modders. Will the next version of openmw have this feature?

Post Reply

Who is online

Users browsing this forum: No registered users and 6 guests