Scene Toolbar Icon Request

Involved development of the OpenMW construction set.
User avatar
Zini
Posts: 5134
Joined: 06 Aug 2011, 15:16

Re: Scene Toolbar Icon Request

Post by Zini » 21 Apr 2016, 09:37

This is probably a cultural thing and somewhere in the world there will be someone protesting that the old version was better. But considering where most of our target audience is located, I agree that this change makes sense.

User avatar
Shnatsel
Posts: 55
Joined: 31 Oct 2014, 01:06
Location: Moscow
Contact:

Re: Scene Toolbar Icon Request

Post by Shnatsel » 21 Apr 2016, 15:31

I think it's more about the modified state in the icon being right next to the actual state of the scene view ;)

Right now the icons are slightly optimized for left-to-right reading, which is why instead of simply flipping the scene view icon I've masked the other half and re-generated the entire set. OpenCS UI layout itself is also optimized for left-to-right reading somewhat - controls on the left of scene view, etc. So for RTL languages just flip the entire layout along with icons and you're done :P

I've edited the arrows on the icon a bit to look better on their own, without the grid:
release.png
release.png (3.84 KiB) Viewed 3560 times
And opened a pull request with flipped scene view icons plus the addition of this icon: https://github.com/OpenMW/openmw/pull/930

Same naming scheme as with scene view icons. First (highest) bit is the grid, second one is for arrows and the last one is for cell marker.

User avatar
Zini
Posts: 5134
Joined: 06 Aug 2011, 15:16

Re: Scene Toolbar Icon Request

Post by Zini » 21 Apr 2016, 15:57

Thanks.

I'm a bit busy right now, so I won't get around to handle the PR and swap out the button until the weekend or maybe even Monday. If any other developer wants to have a shot at it, please be my guest (a good task for newcomers, of which we seem to be getting some recently).

User avatar
Zini
Posts: 5134
Joined: 06 Aug 2011, 15:16

Re: Scene Toolbar Icon Request

Post by Zini » 23 Apr 2016, 12:58

Merged. Now we only have 3 buttons with the "No icon yet" icon (plus whatever the not yet implemented edit modes will add). None of them are at a point yet where adding the icons makes sense. I'll get back to you once the implementation has advanced further. Thanks, again.

Post Reply

Who is online

Users browsing this forum: No registered users and 1 guest