C++11
- psi29a
- Posts: 5361
- Joined: 29 Sep 2011, 10:13
- Location: Belgium
- Gitlab profile: https://gitlab.com/psi29a/
- Contact:
Re: C++11
Not so fast, clang spit it back out:Zini wrote:Okay. Travis ate it (c++11 branch). If there are any modifications required for Windows or Mac, please send a pull request towards that branch.
https://travis-ci.org/OpenMW/openmw/jobs/69862665
-
- Posts: 180
- Joined: 14 Jan 2013, 03:57
Re: C++11
I set it like that since the clang one is using a new version of clang and running it through the static analyzer. I didn't want any bugs in clang or the static analyzer to show up as a build failure, so it is an "allowed failure"Zini wrote:I see. Why is that listed under "Allowed Failures" ? Kinda threw me off
-
- Posts: 180
- Joined: 14 Jan 2013, 03:57
Re: C++11
We can move to building travis in a newer ubuntu release, set up a chroot for trusty or vivid (or newer). You can do something like this:psi29a wrote:Well... because travis-ci requires precise, we're still using its default boost libraries.Zini wrote:Also, what is the oldest version of boost we still need to support? Anything older than 1.51 still in use?
- Boost version: 1.46.1
-- The CXX compiler identification is GNU 4.6.3
-- The C compiler identification is GNU 4.6.3
https://github.com/mingpj2/cxx-ci-trial ... travis.yml
This way you're not stuck with old boost and gcc
Re: C++11
How long does it take to set up this chroot? Let's not do anything that increases build time. We've already hit the 50 minute limit on coverity-scan builds, I had to disable some of the build targets to get it within the time limit again.We can move to building travis in a newer ubuntu release, set up a chroot for trusty or vivid (or newer). You can do something like this:
https://github.com/mingpj2/cxx-ci-trial ... travis.yml
This way you're not stuck with old boost and gcc
-
- Posts: 180
- Joined: 14 Jan 2013, 03:57
Re: C++11
yeah, probably will take at least 10 minutes, I'd guess... just an idea in case someone wanted to tryscrawl wrote:How long does it take to set up this chroot? Let's not do anything that increases build time. We've already hit the 50 minute limit on coverity-scan builds, I had to disable some of the build targets to get it within the time limit again.
-
- Posts: 180
- Joined: 14 Jan 2013, 03:57
Re: C++11
regarding the clang failure:
It's a bug in boost <= 1.48 when compiled with c++11, travis has boost 1.46.
Code: Select all
[ 0%] Building CXX object extern/oics/CMakeFiles/oics.dir/ICSChannel.cpp.o
In file included from /home/travis/build/OpenMW/openmw/extern/osg-ffmpeg-videoplayer/videoplayer.cpp:8:
In file included from /home/travis/build/OpenMW/openmw/extern/osg-ffmpeg-videoplayer/videostate.hpp:6:
In file included from /usr/include/boost/thread.hpp:13:
In file included from /usr/include/boost/thread/thread.hpp:17:
/usr/include/boost/thread/pthread/thread_data.hpp:36:17: error: call to
implicitly-deleted copy constructor of
'boost::shared_ptr<boost::detail::tss_cleanup_function>'
func(func_),value(value_)
^ ~~~~~
/usr/include/boost/smart_ptr/shared_ptr.hpp:347:5: note: copy constructor is
implicitly deleted because
'shared_ptr<boost::detail::tss_cleanup_function>' has a user-declared move
constructor
shared_ptr( shared_ptr && r ): px( r.px ), pn() // never throws
^
In file included from /home/travis/build/OpenMW/openmw/extern/osg-ffmpeg-videoplayer/videoplayer.cpp:8:
In file included from /home/travis/build/OpenMW/openmw/extern/osg-ffmpeg-videoplayer/videostate.hpp:6:
In file included from /usr/include/boost/thread.hpp:13:
In file included from /usr/include/boost/thread/thread.hpp:22:
/usr/include/boost/thread/detail/thread.hpp:395:13: error: call to
implicitly-deleted copy constructor of 'detail::thread_data_ptr' (aka
'shared_ptr<boost::detail::thread_data_base>')
thread_data(thread_data_)
^ ~~~~~~~~~~~~
/usr/include/boost/smart_ptr/shared_ptr.hpp:347:5: note: copy constructor is
implicitly deleted because 'shared_ptr<boost::detail::thread_data_base>'
has a user-declared move constructor
shared_ptr( shared_ptr && r ): px( r.px ), pn() // never throws
^
In file included from /home/travis/build/OpenMW/openmw/extern/osg-ffmpeg-videoplayer/videoplayer.cpp:8:
In file included from /home/travis/build/OpenMW/openmw/extern/osg-ffmpeg-videoplayer/videostate.hpp:6:
In file included from /usr/include/boost/thread.hpp:24:
In file included from /usr/include/boost/thread/future.hpp:14:
In file included from /usr/include/boost/exception_ptr.hpp:9:
In file included from /usr/include/boost/exception/detail/exception_ptr.hpp:20:
/usr/include/boost/exception/info.hpp:102:28: error: call to implicitly-deleted
copy constructor of 'shared_ptr<boost::exception_detail::error_info_base>'
return p;
^
/usr/include/boost/smart_ptr/shared_ptr.hpp:347:5: note: copy constructor is
implicitly deleted because
'shared_ptr<boost::exception_detail::error_info_base>' has a user-declared
move constructor
shared_ptr( shared_ptr && r ): px( r.px ), pn() // never throws
^
In file included from /home/travis/build/OpenMW/openmw/extern/osg-ffmpeg-videoplayer/videoplayer.cpp:8:
In file included from /home/travis/build/OpenMW/openmw/extern/osg-ffmpeg-videoplayer/videostate.hpp:6:
In file included from /usr/include/boost/thread.hpp:24:
In file included from /usr/include/boost/thread/future.hpp:14:
In file included from /usr/include/boost/exception_ptr.hpp:9:
/usr/include/boost/exception/detail/exception_ptr.hpp:83:20: error: call to
implicitly-deleted copy constructor of 'exception_ptr' (aka
'shared_ptr<const exception_detail::clone_base>')
return ep;
^~
/usr/include/boost/smart_ptr/shared_ptr.hpp:347:5: note: copy constructor is
implicitly deleted because 'shared_ptr<const
boost::exception_detail::clone_base>' has a user-declared move constructor
shared_ptr( shared_ptr && r ): px( r.px ), pn() // never throws