Fixes for the 3 issues assigned to me are in my script branch now.
I see 3 more issues related to scripts:
* https://bugs.openmw.org/issues/1546
Seems we are still missing a few instructions even though every script in the 3 default esm files does compile. Not something for 0.32.0.
* https://bugs.openmw.org/issues/1730
Nasty, nasty. But not in the default esm files, so we can release 0.32.0 without a fix.
* https://bugs.openmw.org/issues/1629
Even more nasty. I am not sure what to do about it at this point and would prefer not to rush a fix.
So, all ready on the scripting front from what I see. Does anyone else has anything to report?
OpenMW 0.32.0
Re: OpenMW 0.32.0
Looks like this one has resurfaced (just tested with script branch):
Execution of script galbedirDesk failed:
Failed to access short member variable gemInDesk in script ajiraScript
Re: OpenMW 0.32.0
It never ends.
I don't understand the commit listed in that issue. It removes the case folding for variable names. If anything that should break things more.
I don't understand the commit listed in that issue. It removes the case folding for variable names. If anything that should break things more.
Re: OpenMW 0.32.0
I don't remember what I did there, but I guess case folding was broken somewhere else, so disabling it entirely "fixed" things? Will try if it now works after reverting the commit... Edit: works. Made a PR for reverting it.
Re: OpenMW 0.32.0
Okay, then. Starting RC phase sometimes during next week? Last chance to get your chance in for 0.32.0.
Re: OpenMW 0.32.0
Reporting in.
I will be traveling this coming weekend which will make it difficult to get an early start on a release commentary which will make it difficult to have one ready on release day. But, I am hopeful that I won't be nearly as late as I was last time!
Also, awesome work as always! Getting almost painfully close to v1.0
I will be traveling this coming weekend which will make it difficult to get an early start on a release commentary which will make it difficult to have one ready on release day. But, I am hopeful that I won't be nearly as late as I was last time!
Also, awesome work as always! Getting almost painfully close to v1.0
- sirherrbatka
- Posts: 2159
- Joined: 07 Aug 2011, 17:21
Re: OpenMW 0.32.0
Weirdsexy is currying his posts?I will be traveling this coming weekend which will make it difficult to get an early start on a release commentary which will make it difficult to have one ready on release day.
This is one of those pleasure and pain things, right?Getting almost painfully close to v1.0
- psi29a
- Posts: 5361
- Joined: 29 Sep 2011, 10:13
- Location: Belgium
- Gitlab profile: https://gitlab.com/psi29a/
- Contact:
Re: OpenMW 0.32.0
On the opencs side:
[ 79%] Building CXX object apps/opencs/CMakeFiles/opencs.dir/model/tools/referenceablecheck.cpp.o
/home/bbrick/OpenMW/openmw/apps/opencs/model/tools/referenceablecheck.cpp: In member function ‘void CSMTools::ReferenceableCheckStage::npcCheck(int, const CSMWorld::RefIdDataContainer<ESM::NPC>&, CSMDoc::Stage::Messages&)’:
/home/bbrick/OpenMW/openmw/apps/opencs/model/tools/referenceablecheck.cpp:676:21: warning: comparison is always false due to limited range of data type [-Wtype-limits]
if (disposition < 0)
^
/home/bbrick/OpenMW/openmw/apps/opencs/model/tools/referenceablecheck.cpp:679:20: warning: comparison is always false due to limited range of data type [-Wtype-limits]
if (reputation < 0) //It seems that no character in Morrowind.esm have negative reputation. I'm assuming that negative reputation is invalid
^
/home/bbrick/OpenMW/openmw/apps/opencs/model/tools/referenceablecheck.cpp:686:18: warning: comparison is always false due to limited range of data type [-Wtype-limits]
if (rank < 0)
^
- psi29a
- Posts: 5361
- Joined: 29 Sep 2011, 10:13
- Location: Belgium
- Gitlab profile: https://gitlab.com/psi29a/
- Contact:
Re: OpenMW 0.32.0
On the opencs side:
Code: Select all
[ 79%] Building CXX object apps/opencs/CMakeFiles/opencs.dir/model/tools/referenceablecheck.cpp.o
/home/bbrick/OpenMW/openmw/apps/opencs/model/tools/referenceablecheck.cpp: In member function ‘void CSMTools::ReferenceableCheckStage::npcCheck(int, const CSMWorld::RefIdDataContainer<ESM::NPC>&, CSMDoc::Stage::Messages&)’:
/home/bbrick/OpenMW/openmw/apps/opencs/model/tools/referenceablecheck.cpp:676:21: warning: comparison is always false due to limited range of data type [-Wtype-limits]
if (disposition < 0)
^
/home/bbrick/OpenMW/openmw/apps/opencs/model/tools/referenceablecheck.cpp:679:20: warning: comparison is always false due to limited range of data type [-Wtype-limits]
if (reputation < 0) //It seems that no character in Morrowind.esm have negative reputation. I'm assuming that negative reputation is invalid
^
/home/bbrick/OpenMW/openmw/apps/opencs/model/tools/referenceablecheck.cpp:686:18: warning: comparison is always false due to limited range of data type [-Wtype-limits]
if (rank < 0)
^