.tga files support

Support for running, installing or compiling OpenMW

Before you submit a bug report for the first time, please read: Bug reporting guidelines
GoodBetter
Posts: 5
Joined: 16 Jan 2018, 12:53

.tga files support

Post by GoodBetter » 16 Jan 2018, 14:15

Hello.

One of mods, which I tried, uses .tga to replace magic effects icons. These icons looks fine in vanilla MW, and in Openmw they are just absent (or completely transparent), with no related error messages found in log. They were packed in mod's bsa archive, but I also tried to unpack them to data folder. I found couple of issues in bug tracker regarding tga support - http://bugs.openmw.org/issues/1392 and http://bugs.openmw.org/issues/3180. In second issue, it is mentioned that tga type 2 is supported by osg. Looks like these icons are of type 2 as well (see example in attachments). So, maybe I am missed something?
I run Openmw 0.43 with OSG 3.4.1-1 from official binary Arch Linux repositories.

Any help is much appreciated.
icon.zip
(480 Bytes) Downloaded 5 times
Last edited by GoodBetter on 16 Jan 2018, 14:25, edited 1 time in total.

User avatar
psi29a
Posts: 3501
Joined: 29 Sep 2011, 10:13
Github profile: https://github.com/psi29a/
Contact:

Re: .tga files support

Post by psi29a » 16 Jan 2018, 14:23

This was fixed in our forked version of OSG: https://github.com/OpenMW/osg/pull/6

If you are using an arch's official version, then you'll likely not have the fix. Can you look through the sources to verify?

GoodBetter
Posts: 5
Joined: 16 Jan 2018, 12:53

Re: .tga files support

Post by GoodBetter » 16 Jan 2018, 14:35

psi29a wrote:
16 Jan 2018, 14:23
If you are using an arch's official version, then you'll likely not have the fix. Can you look through the sources to verify?
You were right, source code, provided with package, didn't contain changes from pull request you've linked. So, looks like I need to build OSG from source with this patch applied.

User avatar
psi29a
Posts: 3501
Joined: 29 Sep 2011, 10:13
Github profile: https://github.com/psi29a/
Contact:

Re: .tga files support

Post by psi29a » 16 Jan 2018, 14:45

Or use the PR to make a patch that arch can use and ask them to include it. :)

OR

Use our generic linux build.

User avatar
wareya
Posts: 112
Joined: 09 May 2015, 13:07

Re: .tga files support

Post by wareya » 17 Jan 2018, 01:24

psi29a wrote:
16 Jan 2018, 14:45
Or use the PR to make a patch that arch can use and ask them to include it. :)
Arch applies as few patches as possible to upstream packages, for better and for worse. This is a case where they would definitely not apply the patch.

GoodBetter
Posts: 5
Joined: 16 Jan 2018, 12:53

Re: .tga files support

Post by GoodBetter » 17 Jan 2018, 14:39

I'd like to know, does binary Windows version of Openmw 0.43 includes this patched OSG? Because so far I tried to patch OSG 3.4.1 sources on my linux machine, and it had no effect. I also tried this mod with Windows version of Openmw and had the same result - icons didn't displayed.
Looks like it would be easier to fix this by creating compatibility omwaddon with converted tga files :) (which is anyway required because of 20+ scripts with compile errors in this mod)

User avatar
psi29a
Posts: 3501
Joined: 29 Sep 2011, 10:13
Github profile: https://github.com/psi29a/
Contact:

Re: .tga files support

Post by psi29a » 17 Jan 2018, 15:35

I thought the default behaviour was to prefer the dds over tga files? Or is that not the issue in this case?

User avatar
AnyOldName3
Posts: 646
Joined: 26 Nov 2015, 03:25

Re: .tga files support

Post by AnyOldName3 » 17 Jan 2018, 15:40

I didn't fix the bug so that people could just work around it.

It should be the case that the provided binaries for Windows include the fix, but there could be any number of reasons why that hasn't happened. Either way, though, the image in the zip file at the top of the thread isn't affected by the fix as it should have been supported already. As far as I can tell, the image hasn't got anything wrong with it that would prevent it from working, so unless the OSG TGA plugin was either missing or not registering properly, I can't think of why it wouldn't be working.
AnyOldName3, Master of Shadows

User avatar
AnyOldName3
Posts: 646
Joined: 26 Nov 2015, 03:25

Re: .tga files support

Post by AnyOldName3 » 17 Jan 2018, 15:42

psi29a wrote:
17 Jan 2018, 15:35
I thought the default behaviour was to prefer the dds over tga files? Or is that not the issue in this case?
I think we settled on that behaviour because it was determined to be how vanilla worked, so if the mod works in vanilla it means either that isn't the issue or we've subtly misunderstood what the vanilla behaviour is. It might be the case that vanilla prefers DDS over TGA unless the DDS is in a BSA and the TGA isn't, for example.
AnyOldName3, Master of Shadows

GoodBetter
Posts: 5
Joined: 16 Jan 2018, 12:53

Re: .tga files support

Post by GoodBetter » 18 Jan 2018, 14:24

So, I made simple plugin to test ;) . I placed an example icon into Data Files/Icons folder, and in vanilla CS changed icons of 2 magic effects which belongs to Imperial race abilities. In vanilla MW this icons were changed and correctly displayed in race selection dialogue, in OpenMW 0.43 on Windows, icons were missed, without any fallback images, just transparent. Can anyone else confirm that, please?
icon_test.zip
(2.44 KiB) Downloaded 6 times

Post Reply

Who is online

Users browsing this forum: No registered users and 3 guests