Ubuntu 14.04, Mir, and OpenMW.

Support for running, installing or compiling OpenMW

Before you submit a bug report for the first time, please read: Bug reporting guidelines
User avatar
Sslaxx
Posts: 233
Joined: 12 Aug 2011, 18:59
Location: Malvern, UK
Contact:

Ubuntu 14.04, Mir, and OpenMW.

Post by Sslaxx »

So, with Ubuntu 14.04 stuff has changed (due to the Mir display manager libraries) and it is (as of right now) falling over with:
In file included from /home/stuart/CVS/OpenMW/Source/extern/sdl4ogre/sdlinputwrapper.cpp:2:0:
/usr/include/SDL2/SDL_syswm.h:97:44: fatal error: mir_toolkit/mir_client_library.h: No such file or directory
#include <mir_toolkit/mir_client_library.h>
As far as I can tell, I have all relevant Mir development libraries installed, but throwing this up here in case anyone else has had this happen to them yet, and if so if there's any workaround.
User avatar
pvdk
Posts: 528
Joined: 12 Aug 2011, 16:34

Re: Ubuntu 14.04, Mir, and OpenMW.

Post by pvdk »

Sslaxx wrote:As far as I can tell, I have all relevant Mir development libraries installed, but throwing this up here in case anyone else has had this happen to them yet, and if so if there's any workaround.
Are you sure? That header file should come with the libmirclient-dev package.
maqifrnswa
Posts: 180
Joined: 14 Jan 2013, 03:57

Re: Ubuntu 14.04, Mir, and OpenMW.

Post by maqifrnswa »

ha - i've been fighting this all day, might as well share what I learned...

trusty just enabled MIR with sdl2. However, MIR installs headers in /usr/include/mirclient and requires that to be added to the include path, which by defauly does not. Therefore, it practically requires pkgconfig to tell build systems what include path to -I, and SDL2 doesn't require mir nor includes headers in their pkgconfig file. In addition to all this, FindSDL2.cmake doesn't know anything about mir.

It's too close to a LTS release to implement this change, and this will cause FTBFS all over the archive. Our daily builds caught it, and I've filed a bug with ubuntu asking them to roll back Mir support for SDL2 in trusty since it won't be fully ready in a few days:

https://bugs.launchpad.net/ubuntu/+sour ... ug/1306629

from this project's point of view - I'd suggest waiting until Ubuntu decides what to do.


WORKAROUND:

Code: Select all

Index: openmw/CMakeLists.txt
===================================================================
--- openmw.orig/CMakeLists.txt	2014-04-13 16:17:04.828019705 -0400
+++ openmw/CMakeLists.txt	2014-04-13 21:56:26.832034648 -0400
@@ -278,6 +278,8 @@
 ENDIF(OGRE_STATIC)
 include_directories("."
     ${OGRE_INCLUDE_DIR} ${OGRE_INCLUDE_DIR}/Ogre ${OGRE_INCLUDE_DIR}/OGRE ${OGRE_PLUGIN_INCLUDE_DIRS}
+    /usr/include/mirclient
+    /usr/include/mircommon
     ${SDL2_INCLUDE_DIR}
     ${Boost_INCLUDE_DIR}
     ${PLATFORM_INCLUDE_DIR}
Last edited by maqifrnswa on 14 Apr 2014, 22:19, edited 1 time in total.
User avatar
psi29a
Posts: 5361
Joined: 29 Sep 2011, 10:13
Location: Belgium
Gitlab profile: https://gitlab.com/psi29a/
Contact:

Re: Ubuntu 14.04, Mir, and OpenMW.

Post by psi29a »

I noticed the daily builds failing, but was busy at work and haven't much time to go through it.

I find it strange that they would do something like this so close to release. It isn't as if Mir is default or anything. I find it really strange.
maqifrnswa
Posts: 180
Joined: 14 Jan 2013, 03:57

Re: Ubuntu 14.04, Mir, and OpenMW.

Post by maqifrnswa »

The daily build PPA has been patched to use Mir in trusty. Please test it, it should be built in an hour or so:
https://code.launchpad.net/~openmw/+arc ... enmw-daily

really strange that they enabled it days before release... especially since 14.04 is an LTS release
maqifrnswa
Posts: 180
Joined: 14 Jan 2013, 03:57

Re: Ubuntu 14.04, Mir, and OpenMW.

Post by maqifrnswa »

Here's a quick patch for those that want a workaround:
http://bazaar.launchpad.net/~openmw/ope ... port.patch
User avatar
psi29a
Posts: 5361
Joined: 29 Sep 2011, 10:13
Location: Belgium
Gitlab profile: https://gitlab.com/psi29a/
Contact:

Re: Ubuntu 14.04, Mir, and OpenMW.

Post by psi29a »

maqifrnswa wrote:Here's a quick patch for those that want a workaround:
http://bazaar.launchpad.net/~openmw/ope ... port.patch
Are we going to need these for 0.30 on Debian, or generic enough to include in openmw itself or will this be a Ubuntu specific patch?

I only say this because I can't see the patch:
503 Service Unavailable
maqifrnswa
Posts: 180
Joined: 14 Jan 2013, 03:57

Re: Ubuntu 14.04, Mir, and OpenMW.

Post by maqifrnswa »

BrotherBrick wrote:
maqifrnswa wrote:Here's a quick patch for those that want a workaround:
http://bazaar.launchpad.net/~openmw/ope ... port.patch
Are we going to need these for 0.30 on Debian, or generic enough to include in openmw itself or will this be a Ubuntu specific patch?

I only say this because I can't see the patch:
503 Service Unavailable
won't need it on debian, just trusty+
the patch is here:
viewtopic.php?f=8&t=2131&p=23682#p23682

we can make it generic, use cmake's find_file to see if mir is present and define the variable if so.

Ideally, I'd like ubuntu or mir to fix itself, but this has been reported twice before and the mir devs disregarded it.
User avatar
Sslaxx
Posts: 233
Joined: 12 Aug 2011, 18:59
Location: Malvern, UK
Contact:

Re: Ubuntu 14.04, Mir, and OpenMW.

Post by Sslaxx »

I'm going to assume it's because of Ubuntu planning on switching to Mir in the near future, so I would not expect them to either remove the dependency or to consider this a bug. With this in mind, the source code needs to be patched in order to compile under Trusty (and/or later Ubuntu versions).
maqifrnswa
Posts: 180
Joined: 14 Jan 2013, 03:57

Re: Ubuntu 14.04, Mir, and OpenMW.

Post by maqifrnswa »

Could someone with trusty try:
https://github.com/maqifrnswa/openmw

it needs to be rebased, but it's a simple fix
https://github.com/maqifrnswa/openmw/co ... 661e9fc8e7
Locked