OpenMW 0.18 RC crash after "coc" command on OS X

Support for running, installing or compiling OpenMW

Before you submit a bug report for the first time, please read: Bug reporting guidelines
User avatar
scrawl
Posts: 2152
Joined: 18 Feb 2012, 11:51

Re: OpenMW 0.18 RC crash after "coc" command on OS X

Post by scrawl » 21 Sep 2012, 13:02

Also, the crash should go away when commenting

mWindow->update();

and

MWBase::Environment::get().getInputManager()->update(0, true);

in loadingscreen.cpp?

User avatar
Zini
Posts: 5537
Joined: 06 Aug 2011, 15:16

Re: OpenMW 0.18 RC crash after "coc" command on OS X

Post by Zini » 21 Sep 2012, 13:03

Ah, sorry. I miss-interpreted corristo's posting and then tried to address a problem, that has already been fixed.

Well, I am mostly out of ideas right now. The main loop might be an issue. If that does not help, you will have to debug where in the capture function the crash happens.

corristo
Posts: 495
Joined: 12 Aug 2011, 08:29

Re: OpenMW 0.18 RC crash after "coc" command on OS X

Post by corristo » 21 Sep 2012, 13:46

Disabled custom main loop. Crash is here.

Going to try scrawl's suggestions.

corristo
Posts: 495
Joined: 12 Aug 2011, 08:29

Re: OpenMW 0.18 RC crash after "coc" command on OS X

Post by corristo » 21 Sep 2012, 14:00

Looks like it's sufficient to comment this:

Code: Select all

MWBase::Environment::get().getInputManager()->update(0, true);
And no overflow crash mentioned in commetns above tihs call o_O

User avatar
scrawl
Posts: 2152
Joined: 18 Feb 2012, 11:51

Re: OpenMW 0.18 RC crash after "coc" command on OS X

Post by scrawl » 21 Sep 2012, 16:09

Some more light on the problem:
Due to the implementation of the OSX OIS keyboard, we cannot update input from a listener that was called by the input update. This happened because when using "coc" and pressing enter, the input listener causes a cell change and starts loading, and from this loading method the input is updated again.

I have sent a pull request to disable the input update during loading as a hotfix.

Locked