Page 2 of 2

Re: Awaiting Part 2 of Tour guide (adding ring to game world)

Posted: 27 Feb 2018, 17:24
by psi29a
That's why I raise an ImportError that is then caught later and fills in release information for us: UNRELEASED

That way it won't fail on us if it can't find the version.

Re: Awaiting Part 2 of Tour guide (adding ring to game world)

Posted: 27 Feb 2018, 18:15
by AnyOldName3
No, you don't. You raise an import error if the file is empty, but not if it contains stuff, but not the search term.

Re: Awaiting Part 2 of Tour guide (adding ring to game world)

Posted: 27 Feb 2018, 19:01
by psi29a
Now we do both :D
https://github.com/OpenMW/openmw/commit ... cac8a3c6fa

I figured if we can't find the version, regardless of whatever reason, we set it to UNRELEASED. We print the reason why so we can see it in the logs on RTD but at least we get the latest documentation.