Awaiting Part 2 of Tour guide (adding ring to game world)

Involved development of the OpenMW construction set.
User avatar
psi29a
Posts: 4373
Joined: 29 Sep 2011, 10:13
Github profile: https://github.com/psi29a/
Contact:

Re: Awaiting Part 2 of Tour guide (adding ring to game world)

Post by psi29a » 27 Feb 2018, 17:24

That's why I raise an ImportError that is then caught later and fills in release information for us: UNRELEASED

That way it won't fail on us if it can't find the version.

User avatar
AnyOldName3
Posts: 1193
Joined: 26 Nov 2015, 03:25

Re: Awaiting Part 2 of Tour guide (adding ring to game world)

Post by AnyOldName3 » 27 Feb 2018, 18:15

No, you don't. You raise an import error if the file is empty, but not if it contains stuff, but not the search term.
AnyOldName3, Master of Shadows

User avatar
psi29a
Posts: 4373
Joined: 29 Sep 2011, 10:13
Github profile: https://github.com/psi29a/
Contact:

Re: Awaiting Part 2 of Tour guide (adding ring to game world)

Post by psi29a » 27 Feb 2018, 19:01

Now we do both :D
https://github.com/OpenMW/openmw/commit ... cac8a3c6fa

I figured if we can't find the version, regardless of whatever reason, we set it to UNRELEASED. We print the reason why so we can see it in the logs on RTD but at least we get the latest documentation.

Post Reply

Who is online

Users browsing this forum: No registered users and 10 guests