openmw.org

• [Done] Fix Book records to show Skill IDs instead of Attribute IDs for the teached skill.
• [Done] Change the "Scroll" check box for Book records to a combo box (more user-friendly IMO).
• [Done] Merge the "Skeleton Blood (White)", "Metal Blood (Golden)", and "Default (Red)" blood types for Creature and NPC records into a single combo box. (They can only have one type anyway.)
• Merge the different light emitter types ("Flickering", "Slow Flickering", ...) for Light records into a single combo box. (They can only have one type too.)
• Change the "Female" check box for NPC and Body Part records to a combo box (again, more user-friendly).
• Some cosmetics: fixed typos, added comments to the new/adjusted code.

• Integrate the "Blocked" and "References Persist" flags.
• Make ranks editable in Faction records. (AFAIK, this isn't possible yet.)
• Show actual rank names instead of integers in NPC records.

• Add a "Reference Count" label to records in Objects table.
• Calculate and display encumbrance for Container, Creature, and NPC records.
• Re-arrange record layouts (especially to get rid of the space-consuming "Buys xyz" list in Creature and NPC records). I have already made some concepts for the different record types in the Objects table in Qt Designer.
• Directly limit input in data fields (e.g., 0 ... 100 for disposition).
• Adjust and complete the verifier functions.
• Add detailed tool tips to all entries (with description, limits, enabled/disabled conditions, ...).
• (Implement auto-calculation for NPC records.)

1. My first changes aren't very complex. Should I submit a pull request for every single of them anyway?

3. Should we limit data input to the original limitations present in TES CS? E.g., "Weapon Speed" and "Weapon Reach" values are limited to [0.10 ... 10].

4. How do you feel about fixing typos in our source code? E.g., I have renamed the member variable "mSkillID" to "mSkillId" to fit our naming conventions. There are also several misspelled instances of "referenceables"...

Zini wrote:

3. Should we limit data input to the original limitations present in TES CS? E.g., "Weapon Speed" and "Weapon Reach" values are limited to [0.10 ... 10].

Is there any value to that? Do values outside of this range cause trouble in OpenMW?

Atahualpa wrote: 2. What is the "Faction ID" entry in NPC records for?

#ifndef OPENMW_ESM_BOOK_H
#define OPENMW_ESM_BOOK_H

#include <string>

namespace ESM
{
/*
 * Books, magic scrolls, notes and so on
 */

class ESMReader;
class ESMWriter;

struct Book
{
    static unsigned int sRecordId;
    /// Return a string descriptor for this record type. Currently used for debugging / error logs only.
    static std::string getRecordType() { return "Book"; }

    struct BKDTstruct
    {
        float mWeight; // The book's weight.
		int mValue; // The book's coin value.
		int mIsScroll; // The book's type. (0 = book, 1 = scroll)
		int mSkillId; // What skills does it teach? (0...26 = skill ID, -1 = <none>)
		int mEnchant; // The book's enchantment points.
    };

    BKDTstruct mData; // Subrecord BKDT (20 bytes) --- The book's weight, coin value, book type, teached skill, and enchantment points.
	std::string mName; // Subrecord FNAM --- The book's in-game name. An empty name makes it inaccessible!
	std::string mModel; // Subrecord MODL --- The book's model. Must not be empty!
	std::string mIcon; // Subrecord ITEX --- The book's inventory icon. Must not be empty!
	std::string mScript; // Subrecord SCRI --- The attached script. Optional.
	std::string mEnchant; // Subrecord ENAM --- The book's enchantment. Only scrolls (mIsScroll = true) can have one. Optional.
	std::string mText; // Subrecord TEXT --- The actual book text. Optional.
    std::string mId; // Subrecord NAME --- The book's ID. Not editable.

    void load(ESMReader &esm, bool &isDeleted);
    void save(ESMWriter &esm, bool isDeleted = false) const;

    void blank();
    ///< Set record to default state (does not touch the ID).
};
}
#endif

Subrecord BKDT (20 bytes)

The book's model. Must not be empty!

The book's inventory icon. Must not be empty!

// Subrecord NAME --- The book's ID. Not editable.

scrawl wrote:That is a perfect example of what I consider intrusive and overly verbose comments, which are a waste of time, hard to keep up to date and potentially even harmful. [...]