New OpenMW-CS Icons

[Atahualpa]

Just tested OpenMW-CS with the new icon set - splendid! You've done a great job on these icons, Lamoot.
Of course, not to understate the previous icons made by Shnatsel, but I think the new set fits the clean style of our editor even better.

[akortunov]

https://github.com/OpenMW/openmw/pull/1820

Added icons to menus, based on UniversalId tables.
Some icons are still missing:
1. "File" menu entries
2. "View->New View" icon
3. "View->Toggle Status Bar" icon
4. "World->Objects" icon
5. "World->Instances" icon

[akortunov]

Some screenshots. As I said, I have no icons for some entries:

Screenshot_20180731_095418.png (14.25 KiB) Viewed 2519 times

Screenshot_20180731_095346.png (16.29 KiB) Viewed 2519 times

[Lamoot]

This looks nice. I'll provide the missing icons sometime during 0.45 dev period.

[Atahualpa]

Thanks, akortunov! I always expected icons to appear in the menu bar - and I've tinkered with this exact part of the source code several times...

@Lamoot: It would be great if you managed to create the missing icons before version 0.45 is ready, but there's no hurry.

[Lamoot]

It would be great indeed to have them for 0.45

I put together a mockup, using icons from KDE's Breeze icon theme. Previous CS icons take style inspiration from this set so they fit well together.

One problem I noticed is Breeze icons in dropdown menus are smaller than 16x16 pixels we're using. For example in LibreOffice, they are limited to 12x12 pixels in menus, with larger icons in the toolbar. Using 16x16 size in menus still works for CS, but it doesn't leave empty space around the icons for that really sleek look. In the mockup, compare the 3 top icons for New, Open, Save. That's the difference between the two sizes.

But I'm probably overthinking this and we could simply use 16x16 size for the menus as well to avoid creating 12x12 versions of existing CS icons. Other icon styles in LibreOffice take this approach. What do you think?

[akortunov]

But I'm probably overthinking this and we could simply use 16x16 size for the menus as well to avoid creating 12x12 versions of existing CS icons. Other icon styles in LibreOffice take this approach. What do you think?

Currently my PR uses existing 16x16 icons, so I suggest to keep this behaviour consistent for now.
If the result will be bad, we can use 12x12 icons for menus, but in this case you will need to redraw all existing icons to 12x12 and we will need to provide two icon sets.

[Lamoot]

Yeah 12x12 size would complicate things without much benefit, I'll keep them all 16x16.

This is how the icons would look now. If these look fine I'll go and make a final version (currently it's only a mockup). Some notes:

• For "Objects" I couldn't come up with anything better than a circle, as the category encompases many different entities. A cube would look very similar to the rest of the menu entries and a circle looks like the first letter O.
• "Instances" and "Mesh" share the same icon as I wanted to keep the instances icon the same as it's used in the 3d view editing.
• I tweaked some of the existing icons. The "Cells" now has a green outline and "Magic Effects" has a tweaked design.

[lysol]

Looks awesome!

[fraang]

Just wanted to say: Great work Lamoot. Your effort is very well appreciated.