openmw.org

I want to help with editor. I'm thinking about this task but can switch to something different. How can I help? Where can I find info/doc about LAND record type? Could somebody please break down this task for me?

From what I understand, the LAND data can't be properly represented/edited in a table, so there is not much to do here. The only functionality we might need from the table is to delete, clone or revert to default state. Right Zini?

I've found some docs about record data types.

http://www.uesp.net/morrow/tech/mw_esm.txt
http://www.mwmythicmods.com/argent/tech/es_format.html

So maybe I should work on this bug?
https://bugs.openmw.org/issues/3149

This might help you get started:

https://github.com/cc9cii/openmw/commit ... 2a23344604

The easiest way to deal with bug #3149 is to add columns to mRegions in data.cpp

The land table has two purposes:
- Have a list of land records so the user can see which records exist and which do not
- Monitor the modification status of land records and change it if needed

Therefore the land table would have only two columns:
- ID
- Modification State

Further discussion.
https://github.com/OpenMW/openmw/pull/929

Scenario is add land record, save it, close, open it, save without changes.
https://www.youtube.com/watch?v=JXe-KMN5Xl4

It's on master with merged initial LAND support by cc9cii.
I assume that loading of modified omwgame file skipped some previously saved LAND data and that leads to this behavior.

- open omwgame file
- add land record
- save file
- close
- check size (increased)

- open omwgame file (added records are missing but record count in loading window is increased) 22245
- save file (no changes)
- check size (decreased)

From scenario above (if it's supported) saving (or loading) of LAND records doesn't work in openmw-cs.
Is adding LAND records in editor supported? Does my testing make any sense?

You added a land record with an invalid name. That needs to be handled in the LAND table creator bar. The only valid IDs are of the format #x y
Instead of entering an ID string it might be better to have two integer fields for input.

Anyway, the LAND code wasn't written for that. I guess you may have trashed the data structure. In fact the esm/omwgame file format can not store LAND records with such an ID. No idea what kind of junk ended up being written to the file.