ESX selector and stuff

Involved development of the OpenMW construction set.
graffy
Posts: 142
Joined: 06 Feb 2013, 19:30

Re: ESX selector and stuff

Post by graffy » 22 Sep 2013, 17:31

Yeah, two of those warnings are code issues I'll clean up later this next week. The z-order assignment warning has me puzzled. I've seen that for a while now, but don't know what caused it and haven't really researched it yet. It's on the list, though.

I'll see if I can take care of the adjuster widget and push the changes here soon.

As it stands, is there anything else that needs to get done ASAP? (As I said before, I otherwise plan on not having any further progress to report until the end of this next week...)

User avatar
Zini
Posts: 5134
Joined: 06 Aug 2011, 15:16

Re: ESX selector and stuff

Post by Zini » 22 Sep 2013, 17:57

Only the things I already mentioned (namely support for loading .omwgame/.omwaddon files and adjuster and new file widgets). The rest can wait a bit more.

graffy
Posts: 142
Joined: 06 Feb 2013, 19:30

Re: ESX selector and stuff

Post by graffy » 22 Sep 2013, 19:41

Why do you want the adjuster widget in the edit content portion? Ist selecting the needed file form the combo / table view not sufficient?

User avatar
Zini
Posts: 5134
Joined: 06 Aug 2011, 15:16

Re: ESX selector and stuff

Post by Zini » 22 Sep 2013, 19:44

https://bugs.openmw.org/issues/588

Also, the widget checks, if there already is a file with the same name that would be overwritten and produces a warning in this case.

graffy
Posts: 142
Joined: 06 Feb 2013, 19:30

Re: ESX selector and stuff

Post by graffy » 23 Sep 2013, 05:54

Implemented the file / adjuster widgets for new addon creation. Still needs it for addon content editing. Also still need to fix the sorting / enabling of selected files...

User avatar
Zini
Posts: 5134
Joined: 06 Aug 2011, 15:16

Re: ESX selector and stuff

Post by Zini » 23 Sep 2013, 09:15

That unfortunately does not work. The adjuster widget only shows the leaf name instead of the full path when creating an addon. Not sure if that is a problem in your code or in mine.

User avatar
Zini
Posts: 5134
Joined: 06 Aug 2011, 15:16

Re: ESX selector and stuff

Post by Zini » 23 Sep 2013, 10:28

Okay, both yours and my fault. You didn't configure the adjuster widget correctly, but there is also a bug in the save code. I fixed the forum (on github now) and will now tackle the later.

User avatar
Zini
Posts: 5134
Joined: 06 Aug 2011, 15:16

Re: ESX selector and stuff

Post by Zini » 23 Sep 2013, 10:38

Nope. Also your fault ;) The way the signal from the file dialogue is used to create the document is incorrect. Will fix.

User avatar
Zini
Posts: 5134
Joined: 06 Aug 2011, 15:16

Re: ESX selector and stuff

Post by Zini » 23 Sep 2013, 11:03

Fixed. You might wanna take a look at that, since you need to replicate these changes for the content file editing function. We may also want to add the content file list to the signal instead of fetching them from the widget in the signal handler (cleaner solution). But not that important.

Looks nice. Definitely an improvement over the previous version. The overall look appeals to my minimalistic nature. We probably have to improve the labeling (the window title isn't that great and I am also not convinced by "Project"), but this kind of fine tuning can wait until later.

User avatar
Zini
Posts: 5134
Joined: 06 Aug 2011, 15:16

Re: ESX selector and stuff

Post by Zini » 23 Sep 2013, 11:34

Just loaded the first addon created by OpenCS into OpenMW. Had to rename it, because OpenMW does not yet recognise the new file name extensions, but still a major stealth milestone (I bet no one noticed, that this one was coming).

Post Reply

Who is online

Users browsing this forum: No registered users and 3 guests