Finished my compiler settings review. Will push in a few minutes. Here are the results:
- I re-enabled the warnings 4101, 4146, 4265, 4702. And I also fixed the code that was listed for these warnings. If there are any more problems of the same type, they need to be fixed by someone with MSVC.
- The remaining warnings stay disabled. They are either completely bogus or warn about something that is unlikely to become a problem and would require too much work to get our code warning free to justify the effort.
- For gcc, I added -Wextra, but disabled unused-parameter and unused-but-set-parameter.
- I also disabled the initialiser list order warnings on gcc. These almost never indicate a real problem and I am just sick and tired of constantly having to change the code that comes from MSVC users. Since there doesn't appear to be an equivalent warning on MSVC this is the only option we have.
Master won't compile
-
psi29a
- Posts: 5361
- Joined: 29 Sep 2011, 10:13
- Location: Belgium
- Gitlab profile: https://gitlab.com/psi29a/
- Contact:
Re: Master won't compile
just tested, gcc 4.6.1 compiled clean without warnings. 
Re: Master won't compile
MSVC didn't compile completely without warnings, I've pushed a fix adding a few more virtual destructors that were missing. Shouldn't GCC have noticed them too?
Re: Master won't compile
It should. But doesn't. No idea why.