Git describe shows 0.43.0 on master

Everything about development and the OpenMW source code.
User avatar
psi29a
Posts: 4077
Joined: 29 Sep 2011, 10:13
Github profile: https://github.com/psi29a/
Contact:

Re: Git describe shows 0.43.0 on master

Post by psi29a » 06 Aug 2018, 21:07

raevol wrote:
06 Aug 2018, 19:46
raevol@jabberwock:~/Development/openmw$ git push --tags
Did you read/try the last part of my post? :)

User avatar
raevol
Posts: 2743
Joined: 07 Aug 2011, 01:12
Location: Caldera

Re: Git describe shows 0.43.0 on master

Post by raevol » 06 Aug 2018, 23:23

psi29a wrote:
06 Aug 2018, 21:07
Did you read/try the last part of my post? :)
I read it, and it didn't give me any information that I could act on. I've already said several times that I am a little lost here. Could someone explain to me exactly what I need to do?

Edit: just to reinforce what I am saying here:

Code: Select all

raevol@jabberwock:~/Development/openmw$ git checkout openmw-44
Switched to branch 'openmw-44'
Your branch is up to date with 'origin/openmw-44'.
raevol@jabberwock:~/Development/openmw$ git push --force origin openmw-44
Username for 'https://github.com': mickeylyle
Password for 'https://mickeylyle@github.com': 
Everything up-to-date
raevol@jabberwock:~/Development/openmw$ 

User avatar
Zini
Posts: 5445
Joined: 06 Aug 2011, 15:16

Re: Git describe shows 0.43.0 on master

Post by Zini » 07 Aug 2018, 09:38


User avatar
raevol
Posts: 2743
Joined: 07 Aug 2011, 01:12
Location: Caldera

Re: Git describe shows 0.43.0 on master

Post by raevol » 07 Aug 2018, 10:12

Alright, several things. From Zini's info, I now know I used a lightweight tag instead of an annotated one. Fixed that.

I also named the tag the same as a branch, which is a big no-no. Fixed that, but had to "redo" the github release. I'm sure there's going to be people complaining that their build systems are broken as a result. So sorry, but I'm sure you'll get over it.

And lastly, from the documentation, git describe "finds the most recent tag that is reachable from a commit."

So the openmw-0.44.0 tag is not the "most recent tag" that is "reachable" from the commit master is on now. So that's why it's not showing up with git describe. As far as I can tell, that's perfectly fine.

User avatar
psi29a
Posts: 4077
Joined: 29 Sep 2011, 10:13
Github profile: https://github.com/psi29a/
Contact:

Re: Git describe shows 0.43.0 on master

Post by psi29a » 07 Aug 2018, 10:35

Awesome! Now our PPA nightlies should work again, thanks raevol! :)

User avatar
raevol
Posts: 2743
Joined: 07 Aug 2011, 01:12
Location: Caldera

Re: Git describe shows 0.43.0 on master

Post by raevol » 07 Aug 2018, 10:35

psi29a wrote:
07 Aug 2018, 10:35
Awesome! Now our PPA nightlies should work again, thanks raevol! :)
Not sure if this is sarcasm...

User avatar
Atahualpa
Posts: 904
Joined: 09 Feb 2016, 20:03

Re: Git describe shows 0.43.0 on master

Post by Atahualpa » 07 Aug 2018, 11:13

raevol wrote:
07 Aug 2018, 10:35
psi29a wrote:
07 Aug 2018, 10:35
Awesome! Now our PPA nightlies should work again, thanks raevol! :)
Not sure if this is sarcasm...
Don't blame yourself, raevol. We all make mistakes, and as far as I can tell, the next release will solve that issue for good, right?

User avatar
psi29a
Posts: 4077
Joined: 29 Sep 2011, 10:13
Github profile: https://github.com/psi29a/
Contact:

Re: Git describe shows 0.43.0 on master

Post by psi29a » 07 Aug 2018, 12:36

raevol wrote:
07 Aug 2018, 10:35
psi29a wrote:
07 Aug 2018, 10:35
Awesome! Now our PPA nightlies should work again, thanks raevol! :)
Not sure if this is sarcasm...
None at all, otherwise I would use my [/sarcasm] tag.

I just got home... so I'm catching up. Glad you got it figured out. Yes, our nightlies were stuck on 0.44 but using master to build.... during upload the uploads are rejected because 0.44 already exists.

User avatar
Zini
Posts: 5445
Joined: 06 Aug 2011, 15:16

Re: Git describe shows 0.43.0 on master

Post by Zini » 07 Aug 2018, 12:52

Shit happens. But releasing multiple binaries under the same version number is a bad idea. If we really want to fix this issue, we should do a 0.44.1. Personally, I think this is a bid pointless. 0.45.0 is around the corner anyway.

User avatar
raevol
Posts: 2743
Joined: 07 Aug 2011, 01:12
Location: Caldera

Re: Git describe shows 0.43.0 on master

Post by raevol » 07 Aug 2018, 18:59

Atahualpa wrote:
07 Aug 2018, 11:13
Don't blame yourself, raevol. We all make mistakes, and as far as I can tell, the next release will solve that issue for good, right?
As long as I do the tag right next time. :oops:
psi29a wrote:
07 Aug 2018, 12:36

None at all, otherwise I would use my [/sarcasm] tag.

I just got home... so I'm catching up. Glad you got it figured out. Yes, our nightlies were stuck on 0.44 but using master to build.... during upload the uploads are rejected because 0.44 already exists.
Makes sense!
Zini wrote:
07 Aug 2018, 12:52
Shit happens. But releasing multiple binaries under the same version number is a bad idea.
The tag is still on the same commit. I'm not sure what you mean by binaries, but the release packages weren't even re-uploaded, I just used what is already there since it's the same exact code.

Post Reply

Who is online

Users browsing this forum: No registered users and 2 guests