Exit from start location bug

[Zini]

It seems we have another regression when running the game with the real game start (using the --new-game switch and setting --start to the start location), after existing the ship I end up in the middle of nowhere. Interestingly this does not happen without --new-game. Can anyone confirm?

[swick]

confirmed for the master branch
edit: if you tell me where to search for the bug i'll look into it...
edit2: in mwworld/world.cpp

Code: Select all

        if (newGame)
        {
            // set new game mark
            mGlobalVariables->setInt ("chargenstate", 1);
        }

without this line it works... also I don't find "chargenstate" anywhere else in our code. It must be generated by scripts or by user input, i guess.

[Zini]

In MW chargenstate is a hard-coded variable, that is set depending on if you start a new game or load a game. It affects some scripts that are run on startup. Now the scripts themself can not cause the problem we are seeing. But they are probably using various features of OpenMW and one of these seems to have stopped working. Another aftermath of the MWRender refactoring I guess, located either in MWWorld or MWRender itself.