Pull requests cleanup

Everything about development and the OpenMW source code.
User avatar
akortunov
Posts: 356
Joined: 13 Mar 2017, 13:49
Location: Samara, Russian Federation
Github profile: https://github.com/akortunov

Pull requests cleanup

Post by akortunov » 21 Jul 2017, 20:57

Hello. Currently we have 26 pull requests on OpenMW GitHub repository. A few months ago there were 12 PR's.

Some PR's are more than year old, some did not get any feedback, some have a lot of conflicts with master branch.

Maybe some additional testing is needed, or some additional work to fix these PR's, or some forum discussion.
Or if we can not accept PR's until 1.0, can we add "post-1.0" label?

User avatar
Thunderforge
Posts: 476
Joined: 06 Jun 2017, 05:57
Github profile: https://github.com/Thunderforge

Re: Pull requests cleanup

Post by Thunderforge » 22 Jul 2017, 00:47

I would be in favor of a post 1.0 label. Then when 1.0 is released, all PRs tagged as such are given a grace period to resolve any conflicts with the main, and if they don't do that, we'll assume they are abandoned and delete them.

Probably not a bad idea for the other PRs for before 1.0 too. Put a one month notice or whatever on them and then delete them if not fixed by then.

User avatar
akortunov
Posts: 356
Joined: 13 Mar 2017, 13:49
Location: Samara, Russian Federation
Github profile: https://github.com/akortunov

Re: Pull requests cleanup

Post by akortunov » 23 May 2018, 08:09

Now we have about 50 opened PRs and GitHub page becomes a mess.
Can we do something in this situation?

User avatar
psi29a
Posts: 4077
Joined: 29 Sep 2011, 10:13
Github profile: https://github.com/psi29a/
Contact:

Re: Pull requests cleanup

Post by psi29a » 23 May 2018, 08:18

*cracks knuckles* I'll go through and start pinging people as needed.

@chris and @zini: you guys ready to rock? ;)

(Chris normally is busy with OpenAL-Soft and poking at XLEngine and Zini has his other project he has been working on... I on the other hand have little excuse other than work and 4 children under my roof. ;) )

User avatar
Zini
Posts: 5445
Joined: 06 Aug 2011, 15:16

Re: Pull requests cleanup

Post by Zini » 23 May 2018, 08:39

Well, scrawl wanted to test what happens when he took a break from managing the PRs. Now we know ;)

I am not familiar enough with rendering, AI and physics in OpenMW anymore. Haven't touched this stuff for several years (since I moved most of my attention to the editor). Getting back into that stuff would require more time than I have available. I'll see if I can make some time available on the weekend to sort out at least some of the remaining PRs.

User avatar
Zini
Posts: 5445
Joined: 06 Aug 2011, 15:16

Re: Pull requests cleanup

Post by Zini » 23 May 2018, 12:33

Found a bit of time (while waiting for something else to finish which eats most of my CPU). It seems that appveyor is still having problems. Will ignore it for now since travis is still up and running. Hopefully I can sort out at least a few PRs.

User avatar
Zini
Posts: 5445
Joined: 06 Aug 2011, 15:16

Re: Pull requests cleanup

Post by Zini » 23 May 2018, 13:04

Well, that is two PRs merged. One closed and one given additional feedback. Still progress, I guess.

User avatar
Zini
Posts: 5445
Joined: 06 Aug 2011, 15:16

Re: Pull requests cleanup

Post by Zini » 23 May 2018, 16:20

Down to 44. Still waiting on feedback (and probably some final adjustments) for a couple more and there is one larger PR I need to test more extensively (at the latest on the weekend). That's all I can do for today.

User avatar
Zini
Posts: 5445
Joined: 06 Aug 2011, 15:16

Re: Pull requests cleanup

Post by Zini » 13 Jun 2018, 17:32

Down to only one page of pull requests. Not bad.

User avatar
akortunov
Posts: 356
Joined: 13 Mar 2017, 13:49
Location: Samara, Russian Federation
Github profile: https://github.com/akortunov

Re: Pull requests cleanup

Post by akortunov » 08 Aug 2018, 06:49

IMO, it is time for another cleanup.

Post Reply

Who is online

Users browsing this forum: No registered users and 3 guests