OpenMW Launcher

Everything about development and the OpenMW source code.
Post Reply
User avatar
pvdk
Posts: 523
Joined: 12 Aug 2011, 16:34

OpenMW Launcher

Post by pvdk » 05 Sep 2011, 15:58

Hey,

As I posted in this thread: I fixed the Ogre.cfg bug.
Now I want to move on to the openmw.cfg but I have a hard time remembering what needs to be fixed, sorry :)

Zini, can you please recap the current issue with the launcher?

Regards,
pvdk.

User avatar
Zini
Posts: 5538
Joined: 06 Aug 2011, 15:16

Re: OpenMW Launcher

Post by Zini » 05 Sep 2011, 16:14

This thread sums up the configuration situation.

Currently with the launcher the biggest problem is that only one openmw.cfg file is considered for reading and that the file is then written to this location.

The launcher should merge the openmw.cfg files instead (data and plugins receive special treatment though; see the thread I linked above).

The launcher should only write to the user location (openmw.cfg and other cfg files). Also, when writing openmw.cfg only those parts read from the user location and those parts generated by the launcher should be written (the merged data from other locations should not be written to the user location).

User avatar
pvdk
Posts: 523
Joined: 12 Aug 2011, 16:34

Re: OpenMW Launcher

Post by pvdk » 05 Sep 2011, 17:24

Right, I get it.

Two questions:
1.What about Ogre.cfg? It seems it only gets read from the user directory. Maybe also global but on Linux the file is not writeable and on Windows user and global were the same?

2. What about the local openmw.cfg? Only read/merge, never write?

User avatar
lgromanowski
Site Admin
Posts: 1193
Joined: 05 Aug 2011, 22:21
Location: Wroclaw, Poland
Contact:

Re: OpenMW Launcher

Post by lgromanowski » 05 Sep 2011, 17:57

I made some modifications in launcher code related to configuration changes, please see:
https://github.com/lgromanowski/openmw/ ... 818#diff-0
https://github.com/lgromanowski/openmw/ ... 512#diff-0
best regards,
Lukasz

User avatar
pvdk
Posts: 523
Joined: 12 Aug 2011, 16:34

Re: OpenMW Launcher

Post by pvdk » 05 Sep 2011, 18:03

Does this merge with the changes I made recently? Specifically this commit?

It looks like it does but please send me a pull request or tell me how to pull your changes.

User avatar
lgromanowski
Site Admin
Posts: 1193
Joined: 05 Aug 2011, 22:21
Location: Wroclaw, Poland
Contact:

Re: OpenMW Launcher

Post by lgromanowski » 05 Sep 2011, 18:11

pvdk wrote:Does this merge with the changes I made recently? Specifically this commit?

It looks like it does but please send me a pull request or tell me how to pull your changes.
I don't see "next" branch on your github fork - should I send you pull request to pvdk:master?

// EDIT: Pull request sent (using pvdk:master as a base)
best regards,
Lukasz

User avatar
Zini
Posts: 5538
Joined: 06 Aug 2011, 15:16

Re: OpenMW Launcher

Post by Zini » 05 Sep 2011, 18:36

1.What about Ogre.cfg? It seems it only gets read from the user directory. Maybe also global but on Linux the file is not writeable and on Windows user and global were the same?
The launcher should never write to local or global. On no platform and for no file. Never!

Originally the plan was to look for Ogre.cfg in different locations, but the improved config system will only look for it in the user location. I don't think we get into trouble, if we limit the launcher to the user location; even for the current config system.

Please note, that lgro's changes are for 0.12.0. Your fixes are still meant for 0.11.0.

User avatar
pvdk
Posts: 523
Joined: 12 Aug 2011, 16:34

Re: OpenMW Launcher

Post by pvdk » 06 Sep 2011, 00:22

Ok, it's all clear now. Will start coding tomorrow. In the meantime: can someone on Windows confirm the Ogre changes in my branch work?

About Igro's fixes: for 0.11 these won't be included then. Too bad :(

User avatar
pvdk
Posts: 523
Joined: 12 Aug 2011, 16:34

Re: OpenMW Launcher

Post by pvdk » 06 Sep 2011, 02:54

Done! I hope the code makes sense, I'm going to bed now :)

User avatar
Zini
Posts: 5538
Joined: 06 Aug 2011, 15:16

Re: OpenMW Launcher

Post by Zini » 06 Sep 2011, 08:54

About Igro's fixes: for 0.11 these won't be included then. Too bad
These are a part of a large change and we can't really release them without the other parts finished. This will take a while. We are still planning to release 0.11 soon (what ever soon means in this context).

Post Reply