A few problems with the nightly build

Everything about development and the OpenMW source code.
Post Reply
Allofich
Posts: 104
Joined: 28 May 2016, 12:50

A few problems with the nightly build

Post by Allofich » 07 Feb 2017, 14:08

There's a few problems with the nightly build that need addressing.

One is that it seems to have stopped since d97e9cf, which was on Jan. 29.

But even if it gets going again, currently it would have problems due, I assume, to the recent physics changes. Using the dependencies downloaded with the msvc script I experience partly dropping through the floor on the top floor of "Ald-ruhn, Ald Skar Inn" in the latest revision, and one NPC was shaking around in place due to some physics problem.

Using the latest Bullet (either the latest git repository or the latest release 2.86) seems to have fixed the problem, so I think the nightly build should use a newer version of Bullet.

While we're at it, it would also be good to include the .pdb files produced from a Debug build in with the Bullet libraries. The AppVeyor builds are full of warnings about the missing Bullet .pdb files.

Finally one other thing. There are warnings while building in Visual Studio 2015 about some deprecated functions.

NOTE: Use of this header (bool_trait_def.hpp) is deprecated
NOTE: Use of this header (template_arity_spec.hpp) is deprecated

I haven't tried myself but I read that these would be fixed by upgrading from Boost 1.6.1 to 1.6.2, so that may be something to look at.
https://github.com/objectcomputing/mFAST/issues/52

User avatar
psi29a
Posts: 4676
Joined: 29 Sep 2011, 10:13
Location: Belgium
Gitlab profile: https://gitlab.com/psi29a/
Contact:

Re: A few problems with the nightly build

Post by psi29a » 07 Feb 2017, 14:11

Which nightly build? Ubuntu PPA or Ace's Windows builds?

Updated: I see you mention appveyor and msvc, just for the sake of clarity in the future.. please mention which nightly builds. :D

Allofich
Posts: 104
Joined: 28 May 2016, 12:50

Re: A few problems with the nightly build

Post by Allofich » 07 Feb 2017, 14:12

Ace's Windows builds

Also I should maybe clarify that the only problem I know for sure with the nightly build is that it is stopped, and that the AppVeyor builds complain about missing .pdb files. The others would happen, I assume, based on building locally using the before_script.msvc.sh automated script.

Allofich
Posts: 104
Joined: 28 May 2016, 12:50

Re: A few problems with the nightly build

Post by Allofich » 07 Feb 2017, 14:16

Updated: I see you mention appveyor and msvc, just for the sake of clarity in the future.. please mention which nightly builds.
I wasn't even really aware of the Ubuntu one, since I'm not on Linux, but now I know! So I'll specify which one in the future. :)

User avatar
psi29a
Posts: 4676
Joined: 29 Sep 2011, 10:13
Location: Belgium
Gitlab profile: https://gitlab.com/psi29a/
Contact:

Re: A few problems with the nightly build

Post by psi29a » 07 Feb 2017, 14:35

The problems you mention effect not just appveyor, but travis-ci as well. The warnings about deprecation are external to OpenMW and are fixed by updating boost, so it will be a packaging problem when it does break. My guess a few years from now. ;)

The bullet issue is concerning though. You sure that just by using a newer version that it is fixed? If so, then there was perhaps a bug in the recent change from cylinder to capsule for the collision box.

Allofich
Posts: 104
Joined: 28 May 2016, 12:50

Re: A few problems with the nightly build

Post by Allofich » 07 Feb 2017, 14:42

Building with the Bullet version downloaded by the script, 2.83.7, I have the problem, while using 2.86 I don't. That's the only difference between the builds, so unless I'm making some kind of stupid mistake somewhere, the upgrade to Bullet fixes the issue.

User avatar
scrawl
Posts: 2152
Joined: 18 Feb 2012, 11:51

Re: A few problems with the nightly build

Post by scrawl » 07 Feb 2017, 18:11

Nice find. I noticed similar glitches in other places but hadn't thought of upgrading Bullet. That seems to have fixed everything - I presume it was the btCapsuleShape fixes for 2.86 here: https://github.com/bulletphysics/bullet ... sionShapes

I've updated our cmake script to depend on 2.86. I know, I know someone will start crying out that their distro don't ship that version but come on people, it takes less than 5 minutes to download, compile and install it yourself.

User avatar
psi29a
Posts: 4676
Joined: 29 Sep 2011, 10:13
Location: Belgium
Gitlab profile: https://gitlab.com/psi29a/
Contact:

Re: A few problems with the nightly build

Post by psi29a » 07 Feb 2017, 18:35

/me starts crying

I'll need to backport so that travis builds again, so that means builds are going to start failing. ;)

I'll try to get something up tomorrow.

It also means no more releases on Debian for awhile. Experimental only has 2.85. :/

User avatar
scrawl
Posts: 2152
Joined: 18 Feb 2012, 11:51

Re: A few problems with the nightly build

Post by scrawl » 07 Feb 2017, 18:45

Have a closer look at the commit, I made an exception for travis ;)

User avatar
psi29a
Posts: 4676
Joined: 29 Sep 2011, 10:13
Location: Belgium
Gitlab profile: https://gitlab.com/psi29a/
Contact:

Re: A few problems with the nightly build

Post by psi29a » 07 Feb 2017, 19:03

and appveyor? :)

Update: I see what you did there. ;)

https://github.com/OpenMW/openmw/commit ... 372946251b

Post Reply