PBR and Graphics Improvements implementation

Everything about development and the OpenMW source code.
User avatar
lysol
Posts: 1008
Joined: 26 Mar 2013, 01:48
Location: Sweden

Re: PBR implementation

Post by lysol » 28 Aug 2016, 07:07

Thanks for the links! :)
Normal mapped texture replacers, exclusive for OpenMW:
My Nexus page

User avatar
psi29a
Posts: 4077
Joined: 29 Sep 2011, 10:13
Github profile: https://github.com/psi29a/
Contact:

Re: PBR implementation

Post by psi29a » 28 Aug 2016, 08:18

@Methelina: is this something that we can ship with OpenMW and the user can turn it off and on in settings? Kind of like: Here is Vanilla Morrowind and over here is Vanilla Morrowind "Enhanced". :)

User avatar
Methelina
Posts: 34
Joined: 22 Aug 2016, 09:21
Contact:

Re: PBR implementation

Post by Methelina » 28 Aug 2016, 14:50

psi29a wrote:@Methelina: is this something that we can ship with OpenMW and the user can turn it off and on in settings? Kind of like: Here is Vanilla Morrowind and over here is Vanilla Morrowind "Enhanced". :)
Sure it can be via #DEFINE but every branch made the interpreter slower :shock: But sure it can be switched on and of.
But tbh, pure PBR assets cannot be properly render as nonePBR render, so it can have a difficulties for PBR-only stuff. But i have some ideas how to fix it anyways
Laudate eum de terra
Dracones omnes abyssi
Laudate sol et luna
Stellae Lumen Ignis
Ego dixo
Vadam ad portas inferi
Terribilis est locus iste

User avatar
Ace (SWE)
Posts: 794
Joined: 15 Aug 2011, 14:56

Re: PBR implementation

Post by Ace (SWE) » 28 Aug 2016, 20:02

Why do the switch in-shader? Just have a set of shaders and switch between those in the engine.
If nothing else, it's not all that expensive to do a shader recompile if you decide to turn the option on or off through a #define.

User avatar
Methelina
Posts: 34
Joined: 22 Aug 2016, 09:21
Contact:

Re: PBR implementation

Post by Methelina » 28 Aug 2016, 20:08

Ace (SWE) wrote:Why do the switch in-shader? Just have a set of shaders and switch between those in the engine.
If nothing else, it's not all that expensive to do a shader recompile if you decide to turn the option on or off through a #define.
Cuz its not only shaders, its a lighting, reflection generation, irradiance/radiance and so on.
Anyway first we need something that will work.
i will be glad if someone will help me i need a coder that have a knowledge of the engine
Laudate eum de terra
Dracones omnes abyssi
Laudate sol et luna
Stellae Lumen Ignis
Ego dixo
Vadam ad portas inferi
Terribilis est locus iste

User avatar
Methelina
Posts: 34
Joined: 22 Aug 2016, 09:21
Contact:

Re: PBR implementation

Post by Methelina » 03 Sep 2016, 09:56

This is vry first results in a changing lighting system to the PBR one.
Vry WIP
Spoiler: Show
Laudate eum de terra
Dracones omnes abyssi
Laudate sol et luna
Stellae Lumen Ignis
Ego dixo
Vadam ad portas inferi
Terribilis est locus iste

User avatar
Berandas
Posts: 93
Joined: 28 Oct 2012, 11:23
Location: Prague, Czech Republic
Contact:

Re: PBR implementation

Post by Berandas » 03 Sep 2016, 10:05

First glimpses? Keep it up! ;-)

User avatar
Atahualpa
Posts: 905
Joined: 09 Feb 2016, 20:03

Re: PBR implementation

Post by Atahualpa » 03 Sep 2016, 11:02

Methelina wrote:This is vry first results in a changing lighting system to the PBR one.
Vry WIP
Nice! Looking forward to your next WIP screenshots. :)

User avatar
Methelina
Posts: 34
Joined: 22 Aug 2016, 09:21
Contact:

Re: PBR implementation

Post by Methelina » 03 Sep 2016, 14:52

Thx guys!

Main topic UP

____
we started fork the Shadows

Anyone has info why openMW have no shadows and where the roots of the problem are? Or any another useful information?
Laudate eum de terra
Dracones omnes abyssi
Laudate sol et luna
Stellae Lumen Ignis
Ego dixo
Vadam ad portas inferi
Terribilis est locus iste

User avatar
sjek
Posts: 410
Joined: 22 Nov 2014, 10:51

Re: PBR and Graphics Improvements implementation

Post by sjek » 03 Sep 2016, 16:41

viewtopic.php?f=6&t=2775&hilit=osg+shad ... =30#p31950

if that thread can help. theres some more somewhere but just ask, but specific questions are far better than asking engine documentation althought for specific area : )
open source so best way to get comments on code is from github pull request. here on forums architechture is more common.

as a fan non coder, they aren't yet implemented is osg possibly from perfomance reasons what remember. in 0.36.1 there's still shadows as it's in ogre.

people's free time xP

@scrawl
any general advice on this ?

edit: and there's this one
viewtopic.php?f=2&t=3487&p=38947#p38947
also if i remember right the code was in gusgus github but there's no spefic tag for this so it would be manual search if it's in there anyway, but some technical info
Last edited by sjek on 03 Sep 2016, 17:06, edited 2 times in total.
"life is crazy"
"craziness has beauty which only crazies understand" some movie clip in the head.
https://wiki.openmw.org/index.php?title=Testing

Post Reply

Who is online

Users browsing this forum: No registered users and 2 guests