Unicode issues

Everything about development and the OpenMW source code.
Post Reply
User avatar
greye
Posts: 47
Joined: 21 Jul 2012, 16:00

Unicode issues

Post by greye » 18 May 2014, 08:07

While working on #668 a while ago I discovered several issues on people understanding Unicode conversions between libraries being used. Therefore this page on Wiki is under development. Probably I won't able to finish resolving #668 due to lack of Windows dev-environment and time to set it up, but concept of solution can be found in patch attached (heavily outdated, probably won't merge).
Attachments
wchar.total.patch
(13.58 KiB) Downloaded 114 times
"Always code as if the person who will maintain your code is a maniac serial killer that knows where you live"

User avatar
Zini
Posts: 5537
Joined: 06 Aug 2011, 15:16

Re: Unicode issues

Post by Zini » 18 May 2014, 11:42

Pull request please? We normally don't accept patches in this format.

User avatar
cc9cii
Posts: 497
Joined: 28 Mar 2013, 04:01

Re: Unicode issues

Post by cc9cii » 18 May 2014, 11:57

if the issue is a lack of Windows dev env - I am willing to help. I can have a go at merging the patch to the latest master if you want. However more than likely I will need some help.

User avatar
greye
Posts: 47
Joined: 21 Jul 2012, 16:00

Re: Unicode issues

Post by greye » 18 May 2014, 12:05

cc9cii wrote:if the issue is a lack of Windows dev env - I am willing to help. I can have a go at merging the patch to the latest master if you want. However more than likely I will need some help.
It will be great. It seems like patch applies cleanly to current master, I'll make pull request with note that it is untested.
"Always code as if the person who will maintain your code is a maniac serial killer that knows where you live"

User avatar
cc9cii
Posts: 497
Joined: 28 Mar 2013, 04:01

Re: Unicode issues

Post by cc9cii » 18 May 2014, 23:04

Sorry for crossposting, I left some comments and pics here

User avatar
pvdk
Posts: 523
Joined: 12 Aug 2011, 16:34

Re: Unicode issues

Post by pvdk » 19 May 2014, 20:53

Thanks greye! I noticed the problems with the launcher code when working on the wizard, and I used the correct function there. I hope this fixes the cyrillic path issue on Windows.

User avatar
scrawl
Posts: 2152
Joined: 18 Feb 2012, 11:51

Re: Unicode issues

Post by scrawl » 06 Feb 2015, 18:00

It seems that this issue has cropped up again after the new installation wizard was merged. At least from a user report. From a quick look I don't see any issues in the code though. Could anyone on windows test this?

Post Reply