Zini wrote:I suggest to change the wording of the buttons. "Run Installation Wizard" -> "Rerun Installation Wizard". This indicates that you are modifying an existing installation. Same for "Run Settings Importer".
Well I still intend to make it skippable on first run, so it could actually be the first run of the Wizard.
Zini wrote:"Morrowind installation language" is a bit cryptic. I presume that is the --encoding switch? Maybe rename it into "Legacy Character Encoding". This makes it both clear what it is and that it won't be used for new content files (produced with OpenCS 1.1 and newer). And maybe the combo box should also give the value of the encoding switch (in parenthesis)?
I think "Legacy Character Encoding" is more cryptic than something like "Language of the Morrowind installation," but I like your idea of adding the character encoding to the options, to make it more clear.
Zini wrote:Change the wording from "Install to a new location" to "Install Morrowind to a new location"
and from "Select an existing installation" to "Select an existing Morrowind installation"
Zini wrote:Also, how are you dealing with reruns here? Just append a new data path to the openmw.cfg file? I presume that in the original run this step is skipped when an existing MW installation is found? OpenMW picks up existing installation in default locations automatically. These should not be added to the user openmw.cfg file.
I suggest you try it out
. But right now both options are available whenever the Wizard is run. When you select "existing installation" it does try to pick up the installations from the data= entries. When the user decides to add a path, which is not yet in the list of available installations, it gets added to the openmw.cfg file. To make things clear: it does take into account any default installations, detected in the same way OpenMW itself would.
Zini wrote:I am unsure about the default location. I would have picked the global installation location for MW data files.
Well that would be /usr/share/games on Linux, and writing to that location would require root permissions. This is an XDG compliant path, where stuff like this is supposed to go IMHO.
That would only work, if the existing installation is not in data path already. Otherwise you have MW data files twice in the data path. That might cause problems. Is this case taken care of?
Like I said, it picks up any existing installations by checking if it contains Morrowind.esm and Morrowind.bsa. If those files are present the location is considered an "existing installation." The path is only added when one of the default data= entries did not yield the location already, so no duplication here. Same goes for user-added installations, they only get added as a separate data= entry if they don't already exist in the list of data paths.