Partner Mods

Learn about OpenMW mod compatibility, check for problematic mods, discuss issues, and give us feedback about your experience with modded OpenMW.
Loriel
Posts: 116
Joined: 28 May 2015, 00:44

Re: Partner Mods

Post by Loriel » 18 Aug 2017, 16:32

The problem appears to lie in the implementation of the "SetPos" command - it functions correctly, except when moving an npc from interior to exterior cell - the npc becomes invisible/inactive, but coordinates are apparently updated correctly.

I'm not sure what status the npc has entered - can be recovered by "PositionCell", but not by "enable", and does not follow the player.

The "Position" command seems to have a similar problem, "PositionCell" does not.

EDIT
Suggested simple temporary fix until the SetPos behaviour is fixed:
In each of the 20 scripts cdc_call_compA_script to cdc_call_compT_script insert at line 120:

Code: Select all

	if (getinterior == 0)
		positioncell -21400 -17000 400 0 Balmora
	endif
Resulting in:

Code: Select all

elseif ( portWarp == 3 )		; Move companion and play a sound as a distraction
	PlaySound "mysticism hit"
	set warpz to ( Player->GetPos z )
	set warpz to warpz - 25
	if (getinterior == 0)
		positioncell -21400 -17000 400 0 Balmora
	endif
	SetPos x warpx
	SetPos y warpy
	SetPos z warpz
This checks if the player is in an external cell (using the undocumented "getinterior" function) - if so, the companion is moved to an exterior position (near the Balmora silt strider stand - use a different exterior location if you prefer) using the safe PositionCell command, before using the SetPos commands which now start from an exterior cell and should function correctly.

I am unsure whether the corresponding change needs to be made in cdc_call_comp_script - it hasn't been called during my testing.

Loriel

User avatar
Darklocq
Posts: 36
Joined: 12 Feb 2017, 18:41
Location: California

Re: Partner Mods

Post by Darklocq » 08 Sep 2017, 19:39

Got caught up in work and other stuff. Meant to report a few weeks ago that Companion Teleport worked for a couple of days for me, then just stopped. I haven't gotten it to work since.

I may try moving the mod load order around.

User avatar
Darklocq
Posts: 36
Joined: 12 Feb 2017, 18:41
Location: California

Re: Partner Mods

Post by Darklocq » 08 Sep 2017, 20:09

On the SetPos and Position problem, I opened bug #4088 about it. The earlier #3109 seems to relate or might even be the same issue (but was only filed about Position); that one's had significant debate.

Loriel
Posts: 116
Joined: 28 May 2015, 00:44

Re: Partner Mods

Post by Loriel » 11 Sep 2017, 08:17

Thanks for that.

I see #4088 has now been closed as a duplicate, and discussion continued on #3109.

There is clearly something wrong somewhere in there, stopping Companion Teleportation working as it should, but my earlier analysis was probably too simplistic and I've not yet identified the change from vanilla sufficiently to contribute much more.

Sorry to hear it's stopped working for you - it's working fine for me, with my minor workarounds, and I've also added another small workaround to keep it compatible with the updated MultiMark mod (which redefines "recall").

Loriel

Post Reply

Who is online

Users browsing this forum: GameEnder and 1 guest