Hungarian translate bug

Feedback on past, current, and future development.
Post Reply
awe74
Posts: 5
Joined: 05 Nov 2018, 08:57

Hungarian translate bug

Post by awe74 » 05 Nov 2018, 09:02

Hi!

I have installed hungarian translate, but accents are wrong.
Image
Can someone help me?

User avatar
Capostrophic
Posts: 660
Joined: 22 Feb 2016, 20:32

Re: Hungarian translate bug

Post by Capostrophic » 05 Nov 2018, 10:13

What content language have you set? That affects the assumed encoding of content files. You might have to either use Polish (Win-1250) or English (Win-1252).

awe74
Posts: 5
Joined: 05 Nov 2018, 08:57

Re: Hungarian translate bug

Post by awe74 » 05 Nov 2018, 11:29

This is ESM content decoding table (hex):
AA = ú (*)
AC = á
AB = é (*)
A6 = ő
A3 = ü
87 = ö
A5 = ó (*)
B5 = í
7B = ű
F2 = Á
F1 = É
BB = Ü (*)
BA = Ö (*)
B1 = Í
E7 = Ő
E8 = Ú
BC = Ó

(*) : Wrong letters
Last edited by awe74 on 05 Nov 2018, 13:13, edited 1 time in total.

User avatar
akortunov
Posts: 621
Joined: 13 Mar 2017, 13:49
Location: Samara, Russian Federation

Re: Hungarian translate bug

Post by akortunov » 05 Nov 2018, 12:14

In theory, Hungarian translation should use the win1250 encoding, but your glyphs do not look as a valid encoding.
Does this localization a fan-made? If yes, it may use a custom encoding with custom font files.
So if win1250-win1252 encodings do not work, your localization simply is not supported, as other fan-made ones.

awe74
Posts: 5
Joined: 05 Nov 2018, 08:57

Re: Hungarian translate bug

Post by awe74 » 05 Nov 2018, 12:44

Hungarian translation use custom font.
Attachments
font.zip
Custom font
(81.77 KiB) Downloaded 19 times

awe74
Posts: 5
Joined: 05 Nov 2018, 08:57

Re: Hungarian translate bug

Post by awe74 » 05 Nov 2018, 14:23

Capostrophic wrote:
05 Nov 2018, 10:13
What content language have you set? That affects the assumed encoding of content files. You might have to either use Polish (Win-1250) or English (Win-1252).
English (Win-1252)

User avatar
Capostrophic
Posts: 660
Joined: 22 Feb 2016, 20:32

Re: Hungarian translate bug

Post by Capostrophic » 05 Nov 2018, 15:14

AA = ú (*)
AB = é (*)
A5 = ó (*)
BB = Ü (*)
BA = Ö (*)
AA corresponds to prima ordinal indicator symbol which is replaced with "a".
AB corresponds to double left-pointing angle quotation mark which is replaced with "<".
A5 corresponds to yen sign which is replaced with "Y".
BB corresponds to double right-pointing angle quotation mark which is replaced with ">".
BA corresponds to primo ordinal indicator which is replaced with "o".

This is valid for Windows-1252 encoding and the same glyph replacement is happening in English and Russian versions of the game.
Unless the font could somehow affect that. You could try to install Pelagiad font, there's no glyph replacement for TrueType fonts. Or, again, try to use Polish encoding, maybe that would fix that (probably not).

awe74
Posts: 5
Joined: 05 Nov 2018, 08:57

Re: Hungarian translate bug

Post by awe74 » 06 Nov 2018, 11:03

I have fixed this problem.
5 line modified in the "fontloader.cpp":

additional.insert(std::make_pair(243, 0x00A5)); // yen sign
additional.insert(std::make_pair(250, 0x00AA)); // prima ordinal indicator
additional.insert(std::make_pair(233, 0x00AB)); // double left-pointing angle quotation
additional.insert(std::make_pair(214, 0x00BA)); // primo ordinal indicator
additional.insert(std::make_pair(220, 0x00BB)); // double right-pointing angle quotation

Hungarian translate working perfectly!

Image

User avatar
psi29a
Posts: 4640
Joined: 29 Sep 2011, 10:13
Location: Belgium
Gitlab profile: https://gitlab.com/psi29a/
Contact:

Re: Hungarian translate bug

Post by psi29a » 06 Nov 2018, 11:16

Sweet, send a PR or MR and become a contributor. :)

https://gitlab.com/OpenMW/openmw maybe add an issue on the issue tracker

Post Reply