Elder-scrolls IV Oblivion

Feedback on past, current, and future development.
User avatar
psi29a
Posts: 4260
Joined: 29 Sep 2011, 10:13
Github profile: https://github.com/psi29a/
Contact:

Re: Elder-scrolls IV Oblivion

Post by psi29a » 06 Oct 2018, 12:04

Fantastic! Three cheers for cc9cii! :D

User avatar
cc9cii
Posts: 447
Joined: 28 Mar 2013, 04:01

Re: Elder-scrolls IV Oblivion

Post by cc9cii » 07 Oct 2018, 00:04

Pushed TES4 ESM reader code. Also pushed the bridging code to partially integrate into OpenMW/OpenCS. By partial I mean that the records are thrown away after reading, rather than saving them into data structures for further use. That part of the code needs some more thinking before making them public.

terabyte25
Posts: 38
Joined: 26 Jul 2018, 12:58
Github profile: https://github.com/terabyte25

Re: Elder-scrolls IV Oblivion

Post by terabyte25 » 07 Oct 2018, 01:34

cc9cii wrote:
07 Oct 2018, 00:04
Pushed TES4 ESM reader code. Also pushed the bridging code to partially integrate into OpenMW/OpenCS. By partial I mean that the records are thrown away after reading, rather than saving them into data structures for further use. That part of the code needs some more thinking before making them public.
Godspeed! :lol:

User avatar
psi29a
Posts: 4260
Joined: 29 Sep 2011, 10:13
Github profile: https://github.com/psi29a/
Contact:

Re: Elder-scrolls IV Oblivion

Post by psi29a » 07 Oct 2018, 08:31

Sweet! Glad to hear!

Would you say that this something that can be main-lined after review? From what I see, the branch is still based on the 0.36 release (OGRE), and as such, has a lot of merge conflicts with current master. Is it the plan to eventually rebase/merge? Re-write the work for use in master? Or just have it posted so others are inspired to get it main-lined? Just want to know what the future here is. :D

Example:
https://github.com/OpenMW/openmw/pull/1955

User avatar
cc9cii
Posts: 447
Joined: 28 Mar 2013, 04:01

Re: Elder-scrolls IV Oblivion

Post by cc9cii » 07 Oct 2018, 20:53

The best way would be to cherry-pick some of the commits for review/merge, since many of the changes (especially earlier ones) were already reviewed and not accepted for one reason or another. It's probably best viewed as working examples (or libraries) rather than a pull-request.

terabyte25
Posts: 38
Joined: 26 Jul 2018, 12:58
Github profile: https://github.com/terabyte25

Re: Elder-scrolls IV Oblivion

Post by terabyte25 » 07 Oct 2018, 23:14

@cc9cii Do you mind if I could gift you FO4 on Steam? Thanks in advance.

User avatar
cc9cii
Posts: 447
Joined: 28 Mar 2013, 04:01

Re: Elder-scrolls IV Oblivion

Post by cc9cii » 08 Oct 2018, 01:19

Thanks for the offer, much appreciated. However I would feel better if you donated to a charity of your choice instead - maybe one that supports mental health issues if I may suggest?

The wait for a sale is more to with the thrill of getting a bargain than anything else. Fortunately my days as a poor uni student is long gone.

Post Reply

Who is online

Users browsing this forum: No registered users and 13 guests