Application: trevortknguyen

Join the team. This area is for people who want to participate in OpenMW's development in one way or another.
Post Reply
bosmer
Posts: 3
Joined: 27 Dec 2018, 20:03

Application: trevortknguyen

Post by bosmer » 27 Dec 2018, 22:40

I would like to help on the project. I'm in my first year of undergraduate as an computer science major. I have a decent bit of C++ experience, but no experience in computer science industry yet. I also use Arch Linux.

I've read the developer reference, forked the repository on GitLab, and currently building the latest version.

I understand that there aren't really any beginner-friendly bugs that haven't already been fixed. I also understand that a majority of the development work that is still in progress is relevant to the OpenMW-CS, which is mainly GUI development with Qt. I also understand that making PRs of works in progress is encouraged for feedback, so I will try to do that.

I'm still happy to be here and ready to get started.

User avatar
Capostrophic
Posts: 676
Joined: 22 Feb 2016, 20:32

Re: Application: trevortknguyen

Post by Capostrophic » 27 Dec 2018, 23:28

Hi. There isn't some kind of initiation ritual, but here are some sloppy notes before you get started with your potential first MR:
1. If you have fixed a bug or implemented a feature which have a tracker page, add an entry to CHANGELOG.md for the respective issue.
2. If the thing you have resolved doesn't have a page and it's especially notable (has an apparent effect in the game of some degree), you'll most likely want to file an issue on the tracker and do point 1 then.
3. Feel free to leave your trace in the history add your nickname to AUTHORS.md file in your first contribution.
4. You can use C++11, try to stick to stuff that GCC 5.1 supports.
5. There are most likely still some low-hanging fruits on the tracker on both the editor's and the engine's side. I don't like any of the editor's fruits though.

bosmer
Posts: 3
Joined: 27 Dec 2018, 20:03

Re: Application: trevortknguyen

Post by bosmer » 06 Jan 2019, 03:11

Is there any good documentation on how to start running the tests using Gtest and Gmock?

User avatar
Azdul
Posts: 11
Joined: 28 Dec 2018, 13:44

Re: Application: trevortknguyen

Post by Azdul » 24 Jan 2019, 08:03

bosmer wrote:
06 Jan 2019, 03:11
Is there any good documentation on how to start running the tests using Gtest and Gmock?
Edit:
Oops, nevermind. I've realized that you use Arch Linux.

I've just added "-t" switch to before_script.msvc.sh, which should allow you to run openmw_unit_tests on Windows. openmw_unit_tests should appear as just another project in Visual Studio solution.

User avatar
psi29a
Posts: 4667
Joined: 29 Sep 2011, 10:13
Location: Belgium
Gitlab profile: https://gitlab.com/psi29a/
Contact:

Re: Application: trevortknguyen

Post by psi29a » 24 Jan 2019, 09:55

We don't have anything explicity over testing, but we do have our travis-ci and appveyor builds running tests on the result.

For linux, here are the following related files:
https://gitlab.com/OpenMW/openmw/blob/m ... gletest.sh
^-- to build google's testharness

https://gitlab.com/OpenMW/openmw/blob/m ... t.linux.sh
^-- how to configure openmw's cmake to run the tests

The resulting binary created after you run make is then run:
https://gitlab.com/OpenMW/openmw/blob/m ... is.yml#L94
./openmw_test_suite
So the openmw_test_suite 'project' is our test suite.

I hope this helps!

Post Reply