Page 5 of 6

Re: OpenMW 0.45.0

Posted: 25 Sep 2018, 23:04
by AnyOldName3
It's one of those maybe-requires-a-major-overhaul-of-a-whole-system type issues which is easier to deal with before the system is merged, so I'll only take that approach if my hand is forced.

Re: OpenMW 0.45.0

Posted: 26 Sep 2018, 05:16
by wareya
I checked and vanilla does show shadows for invisible NPCs: https://imgur.com/a/3Ik4WTc

Re: OpenMW 0.45.0

Posted: 26 Sep 2018, 08:01
by akortunov
If shadows from invisible actors are blocker, can we just ignore such actors in shadows calculations (by using masks or something like that)?

Re: OpenMW 0.45.0

Posted: 26 Sep 2018, 12:02
by AnyOldName3
The shadows for invisible actors issue in and of itself is minor. The real issue is that my efforts to solve it have been thwarted by other bugs that aren't a problem otherwise, but seem pretty major.

Using nodemasks would be pretty invasive as we'd have to give every actor an 'actor that isn't invisible' mask and take it away when an invisibility effect is applied and bring it back when it goes. Some invisibility effects leave actors translucent (it might just be the player, though, so you can see where you are), so non-shadow-map rendering would need to use the existing mask so that's visible. I think in cases where an invisibility effect makes something actually invisible, the current implementation does actually ignore it in the shadow map.

Re: OpenMW 0.45.0

Posted: 26 Sep 2018, 12:42
by wareya
Using the nodemask system is definitely the right way to go for something like this, even if it seems gross. "Doesn't cast shadows" is a pretty general thing. For example, future full conversions would probably love to do something like apply it to animated foliage and have AO simulate their internal shadows instead.

Re: OpenMW 0.45.0

Posted: 26 Sep 2018, 14:29
by AnyOldName3
We can't have a "doesn't cast shadows" nodemask as they're ORed with the traversal mask. We'd have to have a duplicate of every mask such that one was "<thing> which doesn't cast shadows" and the other was "<thing> that does cast shadows", with <thing> being actor, static, effect etc.

Re: OpenMW 0.45.0

Posted: 27 Sep 2018, 00:08
by wareya
That sounds like a problem.

Re: OpenMW 0.45.0

Posted: 14 Oct 2018, 10:45
by WhiteGuar
Will ranged criticals be enabled in 0.45? Sorry I didn't know where to look

Re: OpenMW 0.45.0

Posted: 14 Oct 2018, 11:06
by Capostrophic
They're already "enabled" in the sense that they work in the current code - and nightly builds - and they work the same as melee critical hits. There are three conditions:
1) The enemy is not in combat
2) The enemy doesn't see you (line of sight check fails for whatever reason, e.g. you're invisible)
3) The hit is successful

Then the hit is considered critical and has a damage multiplier, a special sound and a message.

Re: OpenMW 0.45.0

Posted: 14 Oct 2018, 11:49
by WhiteGuar
Thank you this is awesome. I read somewhere this would have been implemented after v 1.00. Now that I think about it I'm still using 0.43 so maybe that's why it doesn't work (chameleon 80% + sneak 100 should be more than enough)